From cdeeb36fe44190278d123fa4be4fff5a7d7c8e09 Mon Sep 17 00:00:00 2001 From: Srujan N Date: Mon, 22 Sep 2025 23:23:07 +0000 Subject: [PATCH] test: add comprehensive unit tests for MT940 preprocessing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Added 9 test cases covering all scenarios: - Statement numbers >5 digits truncated correctly (167619 → 67619) - Normal statement numbers (≤5 digits) remain unchanged - Sequence numbers (/1, /2) preserved during truncation - Multiple :28C: occurrences in same document - Edge cases (empty content, missing :28C: tags) - Full MT940 document processing - MT940 format detection with required tags - Boundary conditions (exactly 5/6 digits, very long numbers) - Real-world production case (sanitized for privacy) All tests pass successfully ensuring robust MT940 parsing across various real-world scenarios and edge cases. --- .../test_bank_statement_import.py | 189 +++++++++++++++++- 1 file changed, 185 insertions(+), 4 deletions(-) diff --git a/erpnext/accounts/doctype/bank_statement_import/test_bank_statement_import.py b/erpnext/accounts/doctype/bank_statement_import/test_bank_statement_import.py index 0dc1093fe1e..5e8a3646c48 100644 --- a/erpnext/accounts/doctype/bank_statement_import/test_bank_statement_import.py +++ b/erpnext/accounts/doctype/bank_statement_import/test_bank_statement_import.py @@ -1,10 +1,191 @@ # Copyright (c) 2020, Frappe Technologies and Contributors # See license.txt -# import frappe + import unittest +import frappe -from frappe.tests import IntegrationTestCase +from erpnext.accounts.doctype.bank_statement_import.bank_statement_import import ( + preprocess_mt940_content, + is_mt940_format, +) -class TestBankStatementImport(IntegrationTestCase): - pass +class TestBankStatementImport(unittest.TestCase): + """Unit tests for Bank Statement Import functions""" + + def test_preprocess_mt940_content_with_long_statement_number(self): + """Test that statement numbers longer than 5 digits are truncated to last 5 digits""" + # Test case with 6-digit statement number (167619 -> 67619) + mt940_content = ":28C:167619/1" + expected_content = ":28C:67619/1" + result = preprocess_mt940_content(mt940_content) + self.assertEqual(result, expected_content) + + def test_preprocess_mt940_content_with_normal_statement_number(self): + """Test that statement numbers with 5 or fewer digits are unchanged""" + # Test case with 5-digit statement number (should remain unchanged) + mt940_content = ":28C:12345/1" + result = preprocess_mt940_content(mt940_content) + self.assertEqual(result, mt940_content) # Should be unchanged + + # Test case with 4-digit statement number (should remain unchanged) + mt940_content = ":28C:1234/1" + result = preprocess_mt940_content(mt940_content) + self.assertEqual(result, mt940_content) # Should be unchanged + + def test_preprocess_mt940_content_without_sequence_number(self): + """Test statement number truncation without sequence number""" + # Test case with long statement number but no sequence (no /1) + mt940_content = ":28C:987654321" + expected_content = ":28C:54321" + result = preprocess_mt940_content(mt940_content) + self.assertEqual(result, expected_content) + + def test_preprocess_mt940_content_multiple_occurrences(self): + """Test multiple statement numbers in the same content""" + mt940_content = """:28C:167619/1 +:28C:987654/2""" + expected_content = """:28C:67619/1 +:28C:87654/2""" + result = preprocess_mt940_content(mt940_content) + self.assertEqual(result, expected_content) + + def test_preprocess_mt940_content_edge_cases(self): + """Test edge cases like empty content and content without :28C: tags""" + # Test empty content + self.assertEqual(preprocess_mt940_content(""), "") + + # Test content without :28C: tags + content_without_28c = """:20:STARTUMSE +:25:12345678901234567890 +:60F:C031002EUR0,00""" + result = preprocess_mt940_content(content_without_28c) + self.assertEqual(result, content_without_28c) # Should be unchanged + + def test_preprocess_mt940_content_with_full_mt940_document(self): + """Test preprocessing with complete MT940 document""" + mt940_content = """:20:STARTUMSE +:25:12345678901234567890 +:28C:167619/1 +:60F:C031002EUR0,00 +:61:0310021002DR123,45NMSCNONREF//8327000090031789 +:86:806?20EREF+NONREF?21MREF+M180031?22CRED+DE98ZZZ09999999999 +:62F:C031002EUR-123,45 +-""" + expected_content = """:20:STARTUMSE +:25:12345678901234567890 +:28C:67619/1 +:60F:C031002EUR0,00 +:61:0310021002DR123,45NMSCNONREF//8327000090031789 +:86:806?20EREF+NONREF?21MREF+M180031?22CRED+DE98ZZZ09999999999 +:62F:C031002EUR-123,45 +-""" + result = preprocess_mt940_content(mt940_content) + self.assertEqual(result, expected_content) + + def test_is_mt940_format_detection(self): + """Test MT940 format detection function""" + # Valid MT940 content with all required tags + valid_mt940 = """:20:STARTUMSE +:25:12345678901234567890 +:28C:167619/1 +:60F:C031002EUR0,00 +:61:0310021002DR123,45NMSCNONREF//8327000090031789""" + self.assertTrue(is_mt940_format(valid_mt940)) + + # Invalid MT940 content (CSV format) + invalid_mt940 = """Date,Description,Amount +2023-01-01,Test Transaction,100.00 +2023-01-02,Another Transaction,-50.00""" + self.assertFalse(is_mt940_format(invalid_mt940)) + + # Partially valid MT940 (missing some required tags) + partial_mt940 = """:20:STARTUMSE +:25:12345678901234567890 +:60F:C031002EUR0,00""" + self.assertFalse(is_mt940_format(partial_mt940)) + + # Empty content + self.assertFalse(is_mt940_format("")) + + def test_preprocess_mt940_content_boundary_conditions(self): + """Test boundary conditions for statement number length""" + # Test exactly 6 digits (should be truncated) + mt940_content = ":28C:123456/1" + expected_content = ":28C:23456/1" + result = preprocess_mt940_content(mt940_content) + self.assertEqual(result, expected_content) + + # Test exactly 5 digits (should remain unchanged) + mt940_content = ":28C:12345/1" + result = preprocess_mt940_content(mt940_content) + self.assertEqual(result, mt940_content) + + # Test very long statement number + mt940_content = ":28C:123456789012345/1" + expected_content = ":28C:12345/1" # Last 5 digits + result = preprocess_mt940_content(mt940_content) + self.assertEqual(result, expected_content) + + def test_preprocess_mt940_content_real_world_case(self): + """Test with real-world MT940 content that was failing in production""" + # This is based on actual MT940 content that was causing parsing errors (sanitized) + mt940_content = """{1:F0112345678901X0000000000}{2:I94012345678901XN}{4: +:20:STMTREF167619 +:25:1234567890 +:28C:167619/1 +:60F:C250622USD0,00 +:61:2507170717C100000,00NMSCNOREF +:86:BY EXAMPLE INST 123456/03-07-25/TESTBANK/CITY +:61:2507240724C1,00NMSCNEFTINW-1234567890 +:86:NEFT TEST123456789 EXAMPLE MERCHANT SERVICES +:61:2507310731D305,62NMSCTBMS-1234567890 +:86:Chrg: Debit Card Annual Fee 1234 for 2025 +:61:2508030803D1066,00NMSC123456789 +:86:PCD/1234/EXAMPLE DOMAIN/01234567890123/23:27 +:61:2508060806D2000,00NMSCUPI-123456789 +:86:UPI/TEST USER/123456789/PaidViaTestApp +:61:2508140814D5000,00NMSCUPI-123456789 +:86:UPI/TEST USER/123456789/PaidViaTestApp +:61:2509190919D900,00NMSCUPI-123456789 +:86:UPI/EXAMPLE MERCHANT/123456789/Pay +:61:2509190919D2606,00NMSCUPI-123456789 +:86:UPI/JOHN DOE/123456789/PaidViaTestApp +:62F:C250922USD88123,38 +-}""" + + # Expected result with statement number 167619 truncated to 67619 + expected_content = """{1:F0112345678901X0000000000}{2:I94012345678901XN}{4: +:20:STMTREF167619 +:25:1234567890 +:28C:67619/1 +:60F:C250622USD0,00 +:61:2507170717C100000,00NMSCNOREF +:86:BY EXAMPLE INST 123456/03-07-25/TESTBANK/CITY +:61:2507240724C1,00NMSCNEFTINW-1234567890 +:86:NEFT TEST123456789 EXAMPLE MERCHANT SERVICES +:61:2507310731D305,62NMSCTBMS-1234567890 +:86:Chrg: Debit Card Annual Fee 1234 for 2025 +:61:2508030803D1066,00NMSC123456789 +:86:PCD/1234/EXAMPLE DOMAIN/01234567890123/23:27 +:61:2508060806D2000,00NMSCUPI-123456789 +:86:UPI/TEST USER/123456789/PaidViaTestApp +:61:2508140814D5000,00NMSCUPI-123456789 +:86:UPI/TEST USER/123456789/PaidViaTestApp +:61:2509190919D900,00NMSCUPI-123456789 +:86:UPI/EXAMPLE MERCHANT/123456789/Pay +:61:2509190919D2606,00NMSCUPI-123456789 +:86:UPI/JOHN DOE/123456789/PaidViaTestApp +:62F:C250922USD88123,38 +-}""" + + result = preprocess_mt940_content(mt940_content) + self.assertEqual(result, expected_content) + + # Verify that the problematic statement number was actually changed + self.assertIn(":28C:67619/1", result) + self.assertNotIn(":28C:167619/1", result) + + # Verify that other content remains unchanged + self.assertIn(":20:STMTREF167619", result) # Reference should remain unchanged + self.assertIn("UPI/TEST USER/123456789/PaidViaTestApp", result)