From 6f6133f2e29cf6bb13fd60534e55fd5af940c6c0 Mon Sep 17 00:00:00 2001 From: Rohit Waghchaure Date: Sat, 15 Feb 2025 15:33:41 +0530 Subject: [PATCH] fix: serial no is mandatory for zero qty validation --- .../doctype/stock_reconciliation/stock_reconciliation.js | 5 +++++ .../doctype/stock_reconciliation/stock_reconciliation.py | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js b/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js index 6ba2f0ac051..7f406e5d8c3 100644 --- a/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js +++ b/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.js @@ -262,6 +262,11 @@ frappe.ui.form.on("Stock Reconciliation Item", { qty: function (frm, cdt, cdn) { frm.events.set_amount_quantity(frm, cdt, cdn); + + let row = locals[cdt][cdn]; + if (!row.qty) { + frappe.model.set_value(cdt, cdn, "serial_no", ""); + } }, valuation_rate: function (frm, cdt, cdn) { diff --git a/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py b/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py index adc67c6bb44..d1b81aa2ebe 100644 --- a/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py +++ b/erpnext/stock/doctype/stock_reconciliation/stock_reconciliation.py @@ -250,7 +250,7 @@ class StockReconciliation(StockController): validate_is_stock_item(item_code, item.is_stock_item) # item should not be serialized - if item.has_serial_no and not row.serial_no and not item.serial_no_series: + if item.has_serial_no and row.qty and not row.serial_no and not item.serial_no_series: raise frappe.ValidationError( _("Serial no(s) required for serialized item {0}").format(item_code) )