From ccda17ede2a50ca1bf1612493019d54138dddf12 Mon Sep 17 00:00:00 2001 From: Khushi Rawat <142375893+khushi8112@users.noreply.github.com> Date: Tue, 14 May 2024 20:03:58 +0530 Subject: [PATCH] style: code optimization (cherry picked from commit e843683ad1d90ef046690c66e582237473e1b108) --- erpnext/accounts/doctype/journal_entry/journal_entry.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/erpnext/accounts/doctype/journal_entry/journal_entry.py b/erpnext/accounts/doctype/journal_entry/journal_entry.py index eea4698228d..402f19ee968 100644 --- a/erpnext/accounts/doctype/journal_entry/journal_entry.py +++ b/erpnext/accounts/doctype/journal_entry/journal_entry.py @@ -450,12 +450,11 @@ class JournalEntry(AccountsController): def unlink_asset_reference(self): for d in self.get("accounts"): - root_type = frappe.get_value("Account", d.account, "root_type") if ( self.voucher_type == "Depreciation Entry" and d.reference_type == "Asset" and d.reference_name - and root_type == "Expense" + and frappe.get_cached_value("Account", d.account, "root_type") == "Expense" and d.debit ): asset = frappe.get_doc("Asset", d.reference_name)