nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-28 06:08:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #43612 from blaggacao/refactor/alignment-in-test-record-creation

Browse Source 
test: step 2 refactor towards idempotency
This commit is contained in:
David Arnold
2024-10-13 00:31:30 +02:00
committed by GitHub
parent 727b395e62 8867702f2c
commit cc954d9c67
37 changed files with 247 additions and 294 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
erpnext/setup/doctype/company/test_company.py
View File

@@ -21,7 +21,6 @@ IGNORE_TEST_RECORD_DEPENDENCIES = [
"Warehouse",
]
EXTRA_TEST_RECORD_DEPENDENCIES = ["Fiscal Year"]
test_records = frappe.get_test_records("Company")
class TestCompany(IntegrationTestCase):
@@ -116,7 +115,7 @@ class TestCompany(IntegrationTestCase):
max_rgt = frappe.db.sql("select max(rgt) from `tabCompany`")[0][0]
if not records:
records = test_records[2:]
records = self.globalTestRecords["Company"][2:]
for company in records:
lft, rgt, parent_company = frappe.db.get_value(

6
erpnext/setup/doctype/currency_exchange/test_currency_exchange.py
View File

@@ -9,8 +9,6 @@ from frappe.utils import cint, flt
from erpnext.setup.utils import get_exchange_rate
test_records = frappe.get_test_records("Currency Exchange")
def save_new_records(test_records):
for record in test_records:
@@ -92,7 +90,7 @@ class TestCurrencyExchange(IntegrationTestCase):
self.clear_cache()
def test_exchange_rate(self, mock_get):
save_new_records(test_records)
save_new_records(self.globalTestRecords["Currency Exchange"])
frappe.db.set_single_value("Accounts Settings", "allow_stale", 1)
@@ -117,7 +115,7 @@ class TestCurrencyExchange(IntegrationTestCase):
self.assertEqual(flt(exchange_rate, 3), 65.1)
def test_exchange_rate_via_exchangerate_host(self, mock_get):
save_new_records(test_records)
save_new_records(self.globalTestRecords["Currency Exchange"])
# Update Currency Exchange Rate
settings = frappe.get_single("Currency Exchange Settings")

16
erpnext/setup/doctype/item_group/test_item_group.py
View File

@@ -13,8 +13,6 @@ from frappe.utils.nestedset import (
rebuild_tree,
)
test_records = frappe.get_test_records("Item Group")
class TestItem(IntegrationTestCase):
def test_basic_tree(self, records=None):
@@ -22,7 +20,7 @@ class TestItem(IntegrationTestCase):
max_rgt = frappe.db.sql("select max(rgt) from `tabItem Group`")[0][0]
if not records:
records = test_records[2:]
records = self.globalTestRecords["Item Group"][2:]
for item_group in records:
lft, rgt, parent_item_group = frappe.db.get_value(
@@ -139,7 +137,7 @@ class TestItem(IntegrationTestCase):
)
frappe.delete_doc("Item Group", "_Test Item Group B - 3")
records_to_test = test_records[2:]
records_to_test = self.globalTestRecords["Item Group"][2:]
del records_to_test[4]
self.test_basic_tree(records=records_to_test)
@@ -149,7 +147,7 @@ class TestItem(IntegrationTestCase):
self.assertEqual(new_rgt, item_group.rgt - 2)
# insert it back
frappe.copy_doc(test_records[6]).insert()
frappe.copy_doc(self.globalTestRecords["Item Group"][6]).insert()
self.test_basic_tree()
@@ -159,12 +157,12 @@ class TestItem(IntegrationTestCase):
def test_merge_groups(self):
frappe.rename_doc("Item Group", "_Test Item Group B", "_Test Item Group C", merge=True)
records_to_test = test_records[2:]
records_to_test = self.globalTestRecords["Item Group"][2:]
del records_to_test[1]
self.test_basic_tree(records=records_to_test)
# insert Group B back
frappe.copy_doc(test_records[3]).insert()
frappe.copy_doc(self.globalTestRecords["Item Group"][3]).insert()
self.test_basic_tree()
# move its children back
@@ -180,12 +178,12 @@ class TestItem(IntegrationTestCase):
def test_merge_leaves(self):
frappe.rename_doc("Item Group", "_Test Item Group B - 2", "_Test Item Group B - 1", merge=True)
records_to_test = test_records[2:]
records_to_test = self.globalTestRecords["Item Group"][2:]
del records_to_test[3]
self.test_basic_tree(records=records_to_test)
# insert Group B - 2back
frappe.copy_doc(test_records[5]).insert()
frappe.copy_doc(self.globalTestRecords["Item Group"][5]).insert()
self.test_basic_tree()
def test_merge_leaf_into_group(self):