nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-01 15:47:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #58495 from frappe/mergify/bp/version-16-hotfix/pr-58493

Browse Source 
fix(selling): check quotation write permission before marking lost (backport #58493)
This commit is contained in:
Sudharsanan Ashok
2026-08-28 13:11:58 +05:30
committed by GitHub
parent 23290a60da 4e74831a08
commit cc73c3b879
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/selling/doctype/quotation/quotation.py
View File

@@ -261,7 +261,11 @@ class Quotation(SellingController):
opp.set_status(status=status, update=True) opp.set_status(status=status, update=True)
@frappe.whitelist() @frappe.whitelist()
def declare_enquiry_lost(self, lost_reasons_list, competitors, detailed_reason=None): def declare_enquiry_lost(
self, lost_reasons_list: list, competitors: list, detailed_reason: str | None = None
):
self.check_permission("write")
if not (self.is_fully_ordered() or self.is_partially_ordered()): if not (self.is_fully_ordered() or self.is_partially_ordered()):
get_lost_reasons = frappe.get_list("Quotation Lost Reason", fields=["name"]) get_lost_reasons = frappe.get_list("Quotation Lost Reason", fields=["name"])
lost_reasons_lst = [reason.get("name") for reason in get_lost_reasons] lost_reasons_lst = [reason.get("name") for reason in get_lost_reasons]