From cb9e6f66557caf277def082a32f7823b47c6a2c3 Mon Sep 17 00:00:00 2001 From: rohitwaghchaure Date: Thu, 29 May 2025 10:14:45 +0530 Subject: [PATCH] chore: removed orphaned function (#47796) --- .../controllers/sales_and_purchase_return.py | 95 ------------------- 1 file changed, 95 deletions(-) diff --git a/erpnext/controllers/sales_and_purchase_return.py b/erpnext/controllers/sales_and_purchase_return.py index f25cfbdd465..a7c5b72cbb9 100644 --- a/erpnext/controllers/sales_and_purchase_return.py +++ b/erpnext/controllers/sales_and_purchase_return.py @@ -434,99 +434,6 @@ def make_return_doc(doctype: str, source_name: str, target_doc=None, return_agai else: doc.run_method("calculate_taxes_and_totals") - def update_serial_batch_no(source_doc, target_doc, source_parent, item_details, qty_field): - from erpnext.stock.doctype.serial_no.serial_no import get_serial_nos - from erpnext.stock.serial_batch_bundle import SerialBatchCreation - - returned_serial_nos = [] - returned_batches = frappe._dict() - serial_and_batch_field = ( - "serial_and_batch_bundle" if qty_field == "stock_qty" else "rejected_serial_and_batch_bundle" - ) - old_serial_no_field = "serial_no" if qty_field == "stock_qty" else "rejected_serial_no" - old_batch_no_field = "batch_no" - - if ( - source_doc.get(serial_and_batch_field) - or source_doc.get(old_serial_no_field) - or source_doc.get(old_batch_no_field) - ): - if item_details.has_serial_no: - returned_serial_nos = get_returned_serial_nos( - source_doc, source_parent, serial_no_field=serial_and_batch_field - ) - else: - returned_batches = get_returned_batches( - source_doc, source_parent, batch_no_field=serial_and_batch_field - ) - - type_of_transaction = "Inward" - if source_doc.get(serial_and_batch_field) and ( - frappe.db.get_value( - "Serial and Batch Bundle", source_doc.get(serial_and_batch_field), "type_of_transaction" - ) - == "Inward" - ): - type_of_transaction = "Outward" - elif source_parent.doctype in [ - "Purchase Invoice", - "Purchase Receipt", - "Subcontracting Receipt", - ]: - type_of_transaction = "Outward" - - warehouse = source_doc.warehouse if qty_field == "stock_qty" else source_doc.rejected_warehouse - if source_parent.doctype in [ - "Sales Invoice", - "POS Invoice", - "Delivery Note", - ] and source_parent.get("is_internal_customer"): - type_of_transaction = "Outward" - warehouse = source_doc.target_warehouse - - cls_obj = SerialBatchCreation( - { - "type_of_transaction": type_of_transaction, - "serial_and_batch_bundle": source_doc.get(serial_and_batch_field), - "returned_against": source_doc.name, - "item_code": source_doc.item_code, - "returned_serial_nos": returned_serial_nos, - "voucher_type": source_parent.doctype, - "do_not_submit": True, - "warehouse": warehouse, - "has_serial_no": item_details.has_serial_no, - "has_batch_no": item_details.has_batch_no, - } - ) - - serial_nos = [] - batches = frappe._dict() - if source_doc.get(old_batch_no_field): - batches = frappe._dict({source_doc.batch_no: source_doc.get(qty_field)}) - elif source_doc.get(old_serial_no_field): - serial_nos = get_serial_nos(source_doc.get(old_serial_no_field)) - elif source_doc.get(serial_and_batch_field): - if item_details.has_serial_no: - serial_nos = get_serial_nos_from_bundle(source_doc.get(serial_and_batch_field)) - else: - batches = get_batches_from_bundle(source_doc.get(serial_and_batch_field)) - - if serial_nos: - cls_obj.serial_nos = sorted(list(set(serial_nos) - set(returned_serial_nos))) - elif batches: - for batch in batches: - if batch in returned_batches: - batches[batch] -= flt(returned_batches.get(batch)) - - cls_obj.batches = batches - - if source_doc.get(serial_and_batch_field): - cls_obj.duplicate_package() - if cls_obj.serial_and_batch_bundle: - target_doc.set(serial_and_batch_field, cls_obj.serial_and_batch_bundle) - else: - target_doc.set(serial_and_batch_field, cls_obj.make_serial_and_batch_bundle().name) - def update_item(source_doc, target_doc, source_parent): target_doc.qty = -1 * source_doc.qty target_doc.pricing_rules = None @@ -869,8 +776,6 @@ def get_returned_serial_nos(child_doc, parent_doc, serial_no_field=None, ignore_ def get_returned_batches(child_doc, parent_doc, batch_no_field=None, ignore_voucher_detail_no=None): - from erpnext.stock.serial_batch_bundle import get_batches_from_bundle - batches = frappe._dict() old_field = "batch_no"