From cb693e05bfc71c590dae07184e0fe2af26abbb60 Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Tue, 17 Feb 2026 16:03:25 +0530 Subject: [PATCH] refactor(test): tax rule; removed setUpClass, tearDownClass --- .../bank_clearance/test_bank_clearance.py | 5 +---- .../test_financial_report_template.py | 6 ++--- .../test_opening_invoice_creation_tool.py | 4 +--- .../doctype/pos_invoice/test_pos_invoice.py | 6 +---- .../test_process_statement_of_accounts.py | 15 ++----------- .../test_repost_accounting_ledger.py | 6 +---- .../sales_invoice/test_sales_invoice.py | 22 ++++++------------- .../doctype/tax_rule/test_tax_rule.py | 11 +--------- .../test_tax_withholding_category.py | 4 +--- erpnext/assets/doctype/asset/test_asset.py | 11 +--------- .../test_asset_shift_allocation.py | 4 +--- .../test_supplier_quotation.py | 6 ++--- .../doctype/appointment/test_appointment.py | 6 +---- .../doctype/opportunity/test_opportunity.py | 8 +++---- ...test_opportunity_summary_by_sales_stage.py | 4 +--- erpnext/manufacturing/doctype/bom/test_bom.py | 6 ++--- .../bom_update_log/test_bom_update_log.py | 6 +---- .../bom_update_tool/test_bom_update_tool.py | 6 ++--- .../doctype/job_card/test_job_card.py | 6 +---- .../doctype/routing/test_routing.py | 10 ++------- .../activity_cost/test_activity_cost.py | 8 +++---- .../doctype/quotation/test_quotation.py | 6 ++--- .../doctype/sales_order/test_sales_order.py | 19 +++------------- .../delivery_note/test_delivery_note.py | 6 ++--- .../doctype/item_price/test_item_price.py | 6 ++--- .../test_landed_cost_voucher.py | 6 ++--- .../material_request/test_material_request.py | 6 ++--- .../purchase_receipt/test_purchase_receipt.py | 6 +---- .../stock/doctype/serial_no/test_serial_no.py | 6 ++--- .../test_stock_reconciliation.py | 4 ---- erpnext/stock/tests/test_valuation.py | 6 ++--- .../issue_analytics/test_issue_analytics.py | 13 +++++------ 32 files changed, 60 insertions(+), 184 deletions(-) diff --git a/erpnext/accounts/doctype/bank_clearance/test_bank_clearance.py b/erpnext/accounts/doctype/bank_clearance/test_bank_clearance.py index 0ba4214ffa7..57b33c30e75 100644 --- a/erpnext/accounts/doctype/bank_clearance/test_bank_clearance.py +++ b/erpnext/accounts/doctype/bank_clearance/test_bank_clearance.py @@ -17,9 +17,7 @@ from erpnext.tests.utils import ERPNextTestSuite, if_lending_app_installed, if_l class TestBankClearance(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() + def setUp(self): create_warehouse( warehouse_name="_Test Warehouse", properties={"parent_warehouse": "All Warehouses - _TC"}, @@ -28,7 +26,6 @@ class TestBankClearance(ERPNextTestSuite): create_item("_Test Item") create_cost_center(cost_center_name="_Test Cost Center", company="_Test Company") - def setUp(self): make_bank_account() add_transactions() diff --git a/erpnext/accounts/doctype/financial_report_template/test_financial_report_template.py b/erpnext/accounts/doctype/financial_report_template/test_financial_report_template.py index 2f3bbb36837..9372c503d12 100644 --- a/erpnext/accounts/doctype/financial_report_template/test_financial_report_template.py +++ b/erpnext/accounts/doctype/financial_report_template/test_financial_report_template.py @@ -9,11 +9,9 @@ from erpnext.tests.utils import ERPNextTestSuite class FinancialReportTemplateTestCase(ERPNextTestSuite): """Utility class with common setup and helper methods for all test classes""" - @classmethod - def setUpClass(cls): + def setUp(self): """Set up test data""" - super().setUpClass() - cls.create_test_template() + self.create_test_template() @classmethod def create_test_template(cls): diff --git a/erpnext/accounts/doctype/opening_invoice_creation_tool/test_opening_invoice_creation_tool.py b/erpnext/accounts/doctype/opening_invoice_creation_tool/test_opening_invoice_creation_tool.py index ffcebcf9d1b..3d57c781983 100644 --- a/erpnext/accounts/doctype/opening_invoice_creation_tool/test_opening_invoice_creation_tool.py +++ b/erpnext/accounts/doctype/opening_invoice_creation_tool/test_opening_invoice_creation_tool.py @@ -14,9 +14,7 @@ from erpnext.tests.utils import ERPNextTestSuite class TestOpeningInvoiceCreationTool(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() + def setUp(self): if not frappe.db.exists("Company", "_Test Opening Invoice Company"): make_company() create_dimension() diff --git a/erpnext/accounts/doctype/pos_invoice/test_pos_invoice.py b/erpnext/accounts/doctype/pos_invoice/test_pos_invoice.py index 75b25349608..253df61d87f 100644 --- a/erpnext/accounts/doctype/pos_invoice/test_pos_invoice.py +++ b/erpnext/accounts/doctype/pos_invoice/test_pos_invoice.py @@ -24,14 +24,10 @@ from erpnext.tests.utils import ERPNextTestSuite class POSInvoiceTestMixin(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.load_test_records("Stock Entry") - def setUp(self): from erpnext.accounts.doctype.pos_closing_entry.test_pos_closing_entry import init_user_and_profile + self.load_test_records("Stock Entry") self.test_user, self.pos_profile = init_user_and_profile() if frappe.session.user != "Administrator": diff --git a/erpnext/accounts/doctype/process_statement_of_accounts/test_process_statement_of_accounts.py b/erpnext/accounts/doctype/process_statement_of_accounts/test_process_statement_of_accounts.py index 31d2aa4401f..c16933c7836 100644 --- a/erpnext/accounts/doctype/process_statement_of_accounts/test_process_statement_of_accounts.py +++ b/erpnext/accounts/doctype/process_statement_of_accounts/test_process_statement_of_accounts.py @@ -15,23 +15,12 @@ from erpnext.tests.utils import ERPNextTestSuite class TestProcessStatementOfAccounts(AccountsTestMixin, ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() + def setUp(self): + frappe.db.set_single_value("Selling Settings", "validate_selling_price", 0) letterhead = frappe.get_doc("Letter Head", "Company Letterhead - Grey") letterhead.is_default = 0 letterhead.save() - cls.enterClassContext(cls.change_settings("Selling Settings", validate_selling_price=0)) - @classmethod - def tearDownClass(cls): - super().tearDownClass() - letterhead = frappe.get_doc("Letter Head", "Company Letterhead - Grey") - letterhead.is_default = 1 - letterhead.save() - frappe.db.commit() # nosemgrep - - def setUp(self): self.create_company() self.create_customer() self.create_customer(customer_name="Other Customer") diff --git a/erpnext/accounts/doctype/repost_accounting_ledger/test_repost_accounting_ledger.py b/erpnext/accounts/doctype/repost_accounting_ledger/test_repost_accounting_ledger.py index 274df9fc862..b60c13fc8b8 100644 --- a/erpnext/accounts/doctype/repost_accounting_ledger/test_repost_accounting_ledger.py +++ b/erpnext/accounts/doctype/repost_accounting_ledger/test_repost_accounting_ledger.py @@ -17,15 +17,11 @@ from erpnext.tests.utils import ERPNextTestSuite class TestRepostAccountingLedger(AccountsTestMixin, ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.enterClassContext(cls.change_settings("Selling Settings", validate_selling_price=0)) - def setUp(self): self.create_company() self.create_customer() self.create_item() + frappe.db.set_single_value("Selling Settings", "validate_selling_price", 0) update_repost_settings() def test_01_basic_functions(self): diff --git a/erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py b/erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py index 91fa1f0af0e..700a3082915 100644 --- a/erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py +++ b/erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py @@ -52,6 +52,13 @@ from erpnext.tests.utils import ERPNextTestSuite class TestSalesInvoice(ERPNextTestSuite): def setUp(self): + self.make_employees() + self.make_sales_person() + self.load_test_records("Journal Entry") + self.load_test_records("Stock Entry") + self.load_test_records("Sales Invoice") + unlink_payment_on_cancel_of_invoice() + from erpnext.stock.doctype.stock_ledger_entry.test_stock_ledger_entry import create_items create_items(["_Test Internal Transfer Item"], uoms=[{"uom": "Box", "conversion_factor": 10}]) @@ -93,21 +100,6 @@ class TestSalesInvoice(ERPNextTestSuite): w.submit() return w - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.enterClassContext(cls.change_settings("Selling Settings", validate_selling_price=0)) - cls.make_employees() - cls.make_sales_person() - cls.load_test_records("Journal Entry") - cls.load_test_records("Stock Entry") - cls.load_test_records("Sales Invoice") - unlink_payment_on_cancel_of_invoice() - - @classmethod - def tearDownClass(self): - unlink_payment_on_cancel_of_invoice(0) - def test_sales_invoice_qty(self): si = create_sales_invoice(qty=0, do_not_save=True) with self.assertRaises(InvalidQtyError): diff --git a/erpnext/accounts/doctype/tax_rule/test_tax_rule.py b/erpnext/accounts/doctype/tax_rule/test_tax_rule.py index 4d344c20bbe..cd47d689c60 100644 --- a/erpnext/accounts/doctype/tax_rule/test_tax_rule.py +++ b/erpnext/accounts/doctype/tax_rule/test_tax_rule.py @@ -10,17 +10,8 @@ from erpnext.tests.utils import ERPNextTestSuite class TestTaxRule(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - frappe.db.set_single_value("Shopping Cart Settings", "enabled", 0) - - @classmethod - def tearDownClass(cls): - frappe.db.sql("delete from `tabTax Rule`") - def setUp(self): - frappe.db.sql("delete from `tabTax Rule`") + frappe.db.set_single_value("Shopping Cart Settings", "enabled", 0) def test_conflict(self): tax_rule1 = make_tax_rule( diff --git a/erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py b/erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py index 3d8307805ef..66dc090f7c7 100644 --- a/erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py +++ b/erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py @@ -14,9 +14,7 @@ from erpnext.tests.utils import ERPNextTestSuite class TestTaxWithholdingCategory(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() + def setUp(self): # create relevant supplier, etc create_records() create_tax_withholding_category_records() diff --git a/erpnext/assets/doctype/asset/test_asset.py b/erpnext/assets/doctype/asset/test_asset.py index b4772930611..91ab627b113 100644 --- a/erpnext/assets/doctype/asset/test_asset.py +++ b/erpnext/assets/doctype/asset/test_asset.py @@ -903,18 +903,9 @@ class TestAsset(AssetSetup): class TestDepreciationMethods(AssetSetup): - @classmethod - def setUpClass(cls): - super().setUpClass() - - cls._old_float_precision = frappe.db.get_single_value("System Settings", "float_precision") + def setUp(self): frappe.db.set_single_value("System Settings", "float_precision", 2) - @classmethod - def tearDownClass(cls): - frappe.db.set_single_value("System Settings", "float_precision", cls._old_float_precision) - super().tearDownClass() - def test_schedule_for_straight_line_method(self): asset = create_asset( calculate_depreciation=1, diff --git a/erpnext/assets/doctype/asset_shift_allocation/test_asset_shift_allocation.py b/erpnext/assets/doctype/asset_shift_allocation/test_asset_shift_allocation.py index 8fba5602602..5b1cdaf0277 100644 --- a/erpnext/assets/doctype/asset_shift_allocation/test_asset_shift_allocation.py +++ b/erpnext/assets/doctype/asset_shift_allocation/test_asset_shift_allocation.py @@ -12,9 +12,7 @@ from erpnext.tests.utils import ERPNextTestSuite class TestAssetShiftAllocation(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() + def setUp(self): create_asset_shift_factors() def test_asset_shift_allocation(self): diff --git a/erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py b/erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py index d6ff71322e7..c271d34b35d 100644 --- a/erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py +++ b/erpnext/buying/doctype/supplier_quotation/test_supplier_quotation.py @@ -14,10 +14,8 @@ from erpnext.tests.utils import ERPNextTestSuite class TestPurchaseOrder(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.load_test_records("Supplier Quotation") + def setUp(self): + self.load_test_records("Supplier Quotation") def test_update_child_supplier_quotation_add_item(self): sq = frappe.copy_doc(self.globalTestRecords["Supplier Quotation"][0]) diff --git a/erpnext/crm/doctype/appointment/test_appointment.py b/erpnext/crm/doctype/appointment/test_appointment.py index e0b0a5118ff..83eacca83b6 100644 --- a/erpnext/crm/doctype/appointment/test_appointment.py +++ b/erpnext/crm/doctype/appointment/test_appointment.py @@ -27,12 +27,8 @@ def create_test_appointment(): class TestAppointment(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - frappe.db.delete("Lead", {"email_id": LEAD_EMAIL}) - def setUp(self): + frappe.db.delete("Lead", {"email_id": LEAD_EMAIL}) self.test_appointment = create_test_appointment() self.test_appointment.set_verified(self.test_appointment.customer_email) diff --git a/erpnext/crm/doctype/opportunity/test_opportunity.py b/erpnext/crm/doctype/opportunity/test_opportunity.py index 3a63147f384..da8530115a7 100644 --- a/erpnext/crm/doctype/opportunity/test_opportunity.py +++ b/erpnext/crm/doctype/opportunity/test_opportunity.py @@ -12,13 +12,11 @@ from erpnext.tests.utils import ERPNextTestSuite class TestOpportunity(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() + def setUp(self): # Only first lead is required # TODO: dynamically generate limited test records - cls.make_leads() - cls.make_opportunities() + self.make_leads() + self.make_opportunities() @classmethod def make_opportunities(cls): diff --git a/erpnext/crm/report/opportunity_summary_by_sales_stage/test_opportunity_summary_by_sales_stage.py b/erpnext/crm/report/opportunity_summary_by_sales_stage/test_opportunity_summary_by_sales_stage.py index f136294339f..4d5ba1dc9a2 100644 --- a/erpnext/crm/report/opportunity_summary_by_sales_stage/test_opportunity_summary_by_sales_stage.py +++ b/erpnext/crm/report/opportunity_summary_by_sales_stage/test_opportunity_summary_by_sales_stage.py @@ -8,9 +8,7 @@ from erpnext.tests.utils import ERPNextTestSuite class TestOpportunitySummaryBySalesStage(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() + def setUp(self): create_opportunity() def test_opportunity_summary_by_sales_stage(self): diff --git a/erpnext/manufacturing/doctype/bom/test_bom.py b/erpnext/manufacturing/doctype/bom/test_bom.py index e09293c0f9d..40cbd3b5c41 100644 --- a/erpnext/manufacturing/doctype/bom/test_bom.py +++ b/erpnext/manufacturing/doctype/bom/test_bom.py @@ -24,10 +24,8 @@ from erpnext.tests.utils import ERPNextTestSuite class TestBOM(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.load_test_records("BOM") + def setUp(self): + self.load_test_records("BOM") @timeout def test_get_items(self): diff --git a/erpnext/manufacturing/doctype/bom_update_log/test_bom_update_log.py b/erpnext/manufacturing/doctype/bom_update_log/test_bom_update_log.py index d44a9284f0f..ea2f8df8cc6 100644 --- a/erpnext/manufacturing/doctype/bom_update_log/test_bom_update_log.py +++ b/erpnext/manufacturing/doctype/bom_update_log/test_bom_update_log.py @@ -17,12 +17,8 @@ from erpnext.tests.utils import ERPNextTestSuite class TestBOMUpdateLog(ERPNextTestSuite): "Test BOM Update Tool Operations via BOM Update Log." - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.load_test_records("BOM") - def setUp(self): + self.load_test_records("BOM") bom_doc = frappe.copy_doc(self.globalTestRecords["BOM"][0]) bom_doc.items[1].item_code = "_Test Item" bom_doc.insert() diff --git a/erpnext/manufacturing/doctype/bom_update_tool/test_bom_update_tool.py b/erpnext/manufacturing/doctype/bom_update_tool/test_bom_update_tool.py index 9b433a9c1d6..c035dccd06c 100644 --- a/erpnext/manufacturing/doctype/bom_update_tool/test_bom_update_tool.py +++ b/erpnext/manufacturing/doctype/bom_update_tool/test_bom_update_tool.py @@ -16,10 +16,8 @@ from erpnext.tests.utils import ERPNextTestSuite class TestBOMUpdateTool(ERPNextTestSuite): "Test major functions run via BOM Update Tool." - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.load_test_records("BOM") + def setUp(self): + self.load_test_records("BOM") @timeout def test_replace_bom(self): diff --git a/erpnext/manufacturing/doctype/job_card/test_job_card.py b/erpnext/manufacturing/doctype/job_card/test_job_card.py index c23723ef012..0d36f106999 100644 --- a/erpnext/manufacturing/doctype/job_card/test_job_card.py +++ b/erpnext/manufacturing/doctype/job_card/test_job_card.py @@ -27,12 +27,8 @@ from erpnext.tests.utils import ERPNextTestSuite class TestJobCard(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.load_test_records("BOM") - def setUp(self): + self.load_test_records("BOM") self.make_employees() # used in job card time log self.make_bom_for_jc_tests() self.transfer_material_against: Literal["Work Order", "Job Card"] = "Work Order" diff --git a/erpnext/manufacturing/doctype/routing/test_routing.py b/erpnext/manufacturing/doctype/routing/test_routing.py index 0c53096f6a8..4575c1d1d57 100644 --- a/erpnext/manufacturing/doctype/routing/test_routing.py +++ b/erpnext/manufacturing/doctype/routing/test_routing.py @@ -9,14 +9,8 @@ from erpnext.tests.utils import ERPNextTestSuite class TestRouting(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.item_code = "Test Routing Item - A" - - @classmethod - def tearDownClass(cls): - frappe.db.sql("delete from tabBOM where item=%s", cls.item_code) + def setUp(self): + self.item_code = "Test Routing Item - A" def test_sequence_id(self): operations = [ diff --git a/erpnext/projects/doctype/activity_cost/test_activity_cost.py b/erpnext/projects/doctype/activity_cost/test_activity_cost.py index a4f20fe7f06..1e8708cadf3 100644 --- a/erpnext/projects/doctype/activity_cost/test_activity_cost.py +++ b/erpnext/projects/doctype/activity_cost/test_activity_cost.py @@ -8,12 +8,10 @@ from erpnext.tests.utils import ERPNextTestSuite class TestActivityCost(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() + def setUp(self): # TODO: only 1 employee is required - cls.make_employees() - cls.make_activity_type() + self.make_employees() + self.make_activity_type() def test_duplication(self): frappe.db.sql("delete from `tabActivity Cost`") diff --git a/erpnext/selling/doctype/quotation/test_quotation.py b/erpnext/selling/doctype/quotation/test_quotation.py index 2a8d582f8fb..b841f456bc9 100644 --- a/erpnext/selling/doctype/quotation/test_quotation.py +++ b/erpnext/selling/doctype/quotation/test_quotation.py @@ -13,10 +13,8 @@ from erpnext.tests.utils import ERPNextTestSuite class TestQuotation(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.load_test_records("Quotation") + def setUp(self): + self.load_test_records("Quotation") def test_update_child_quotation_add_item(self): from erpnext.stock.doctype.item.test_item import make_item diff --git a/erpnext/selling/doctype/sales_order/test_sales_order.py b/erpnext/selling/doctype/sales_order/test_sales_order.py index d87aa6e275c..d738721c767 100644 --- a/erpnext/selling/doctype/sales_order/test_sales_order.py +++ b/erpnext/selling/doctype/sales_order/test_sales_order.py @@ -36,21 +36,6 @@ from erpnext.tests.utils import ERPNextTestSuite class TestSalesOrder(AccountsTestMixin, ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.unlink_setting = int( - frappe.db.get_single_value("Accounts Settings", "unlink_advance_payment_on_cancelation_of_order") - ) - - @classmethod - def tearDownClass(cls) -> None: - # reset config to previous state - frappe.db.set_single_value( - "Accounts Settings", "unlink_advance_payment_on_cancelation_of_order", cls.unlink_setting - ) - super().tearDownClass() - def setUp(self): self.create_customer("_Test Customer Credit") @@ -141,7 +126,9 @@ class TestSalesOrder(AccountsTestMixin, ERPNextTestSuite): so.reload() self.assertEqual(so.status, "Completed") - @ERPNextTestSuite.change_settings("Selling Settings", {"allow_multiple_items": 1, "allow_negative_rates_for_items": 1}) + @ERPNextTestSuite.change_settings( + "Selling Settings", {"allow_multiple_items": 1, "allow_negative_rates_for_items": 1} + ) def test_sales_order_with_negative_rate(self): """ Test if negative rate is allowed in Sales Order via doc submission and update items diff --git a/erpnext/stock/doctype/delivery_note/test_delivery_note.py b/erpnext/stock/doctype/delivery_note/test_delivery_note.py index fda07be08f6..480d54ac505 100644 --- a/erpnext/stock/doctype/delivery_note/test_delivery_note.py +++ b/erpnext/stock/doctype/delivery_note/test_delivery_note.py @@ -45,10 +45,8 @@ from erpnext.tests.utils import ERPNextTestSuite class TestDeliveryNote(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.load_test_records("Stock Entry") + def setUp(self): + self.load_test_records("Stock Entry") def test_delivery_note_qty(self): dn = create_delivery_note(qty=0, do_not_save=True) diff --git a/erpnext/stock/doctype/item_price/test_item_price.py b/erpnext/stock/doctype/item_price/test_item_price.py index f60dcc98e0d..f2f177dd8fe 100644 --- a/erpnext/stock/doctype/item_price/test_item_price.py +++ b/erpnext/stock/doctype/item_price/test_item_price.py @@ -11,10 +11,8 @@ from erpnext.tests.utils import ERPNextTestSuite class TestItemPrice(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.load_test_records("Item Price") + def setUp(self): + self.load_test_records("Item Price") def test_template_item_price(self): from erpnext.stock.doctype.item.test_item import make_item diff --git a/erpnext/stock/doctype/landed_cost_voucher/test_landed_cost_voucher.py b/erpnext/stock/doctype/landed_cost_voucher/test_landed_cost_voucher.py index 9203142caeb..8bb1d327891 100644 --- a/erpnext/stock/doctype/landed_cost_voucher/test_landed_cost_voucher.py +++ b/erpnext/stock/doctype/landed_cost_voucher/test_landed_cost_voucher.py @@ -24,10 +24,8 @@ from erpnext.tests.utils import ERPNextTestSuite class TestLandedCostVoucher(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.load_test_records("Currency Exchange") + def setUp(self): + self.load_test_records("Currency Exchange") def test_landed_cost_voucher(self): frappe.db.set_single_value("Buying Settings", "allow_multiple_items", 1) diff --git a/erpnext/stock/doctype/material_request/test_material_request.py b/erpnext/stock/doctype/material_request/test_material_request.py index 82a61fcbb8d..e72637901b5 100644 --- a/erpnext/stock/doctype/material_request/test_material_request.py +++ b/erpnext/stock/doctype/material_request/test_material_request.py @@ -24,10 +24,8 @@ from erpnext.tests.utils import ERPNextTestSuite class TestMaterialRequest(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.load_test_records("Material Request") + def setUp(self): + self.load_test_records("Material Request") def test_material_request_qty(self): mr = frappe.copy_doc(self.globalTestRecords["Material Request"][0]) diff --git a/erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py b/erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py index 9cd9cb7aaba..20ea5459e1f 100644 --- a/erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py +++ b/erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py @@ -29,13 +29,9 @@ from erpnext.tests.utils import ERPNextTestSuite class TestPurchaseReceipt(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.load_test_records("Purchase Receipt") - def setUp(self): frappe.local.future_sle = {} + self.load_test_records("Purchase Receipt") def test_purchase_receipt_qty(self): pr = make_purchase_receipt(qty=0, rejected_qty=0, do_not_save=True) diff --git a/erpnext/stock/doctype/serial_no/test_serial_no.py b/erpnext/stock/doctype/serial_no/test_serial_no.py index fecd4fb672e..a82cbe5d306 100644 --- a/erpnext/stock/doctype/serial_no/test_serial_no.py +++ b/erpnext/stock/doctype/serial_no/test_serial_no.py @@ -23,10 +23,8 @@ from erpnext.tests.utils import ERPNextTestSuite class TestSerialNo(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - cls.load_test_records("Stock Entry") + def setUp(self): + self.load_test_records("Stock Entry") def test_cannot_create_direct(self): frappe.delete_doc_if_exists("Serial No", "_TCSER0001") diff --git a/erpnext/stock/doctype/stock_reconciliation/test_stock_reconciliation.py b/erpnext/stock/doctype/stock_reconciliation/test_stock_reconciliation.py index cdda5cffe5d..99231878f06 100644 --- a/erpnext/stock/doctype/stock_reconciliation/test_stock_reconciliation.py +++ b/erpnext/stock/doctype/stock_reconciliation/test_stock_reconciliation.py @@ -34,10 +34,6 @@ from erpnext.tests.utils import ERPNextTestSuite class TestStockReconciliation(ERPNextTestSuite, StockTestMixin): - @classmethod - def setUpClass(cls): - super().setUpClass() - def setUp(self): frappe.db.set_single_value("Stock Settings", "allow_negative_stock", 1) frappe.local.future_sle = {} diff --git a/erpnext/stock/tests/test_valuation.py b/erpnext/stock/tests/test_valuation.py index c151048ff0a..14963f8a595 100644 --- a/erpnext/stock/tests/test_valuation.py +++ b/erpnext/stock/tests/test_valuation.py @@ -310,10 +310,8 @@ class TestLIFOValuationSLE(ERPNextTestSuite): ITEM_CODE = "_Test LIFO item" WAREHOUSE = "_Test Warehouse - _TC" - @classmethod - def setUpClass(cls) -> None: - super().setUpClass() - make_item(cls.ITEM_CODE, {"valuation_method": "LIFO"}) + def setUp(self) -> None: + make_item(self.ITEM_CODE, {"valuation_method": "LIFO"}) def _make_stock_entry(self, qty, rate=None): kwargs = { diff --git a/erpnext/support/report/issue_analytics/test_issue_analytics.py b/erpnext/support/report/issue_analytics/test_issue_analytics.py index 9f2729cf947..94126b2708c 100644 --- a/erpnext/support/report/issue_analytics/test_issue_analytics.py +++ b/erpnext/support/report/issue_analytics/test_issue_analytics.py @@ -13,19 +13,16 @@ months = ["Jan", "Feb", "Mar", "Apr", "May", "Jun", "Jul", "Aug", "Sep", "Oct", class TestIssueAnalytics(ERPNextTestSuite): - @classmethod - def setUpClass(cls): - super().setUpClass() - frappe.db.sql("delete from `tabIssue` where company='_Test Company'") + def setUp(self): frappe.db.set_single_value("Support Settings", "track_service_level_agreement", 1) current_month_date = getdate() last_month_date = add_months(current_month_date, -1) - cls.current_month = str(months[current_month_date.month - 1]).lower() - cls.last_month = str(months[last_month_date.month - 1]).lower() + self.current_month = str(months[current_month_date.month - 1]).lower() + self.last_month = str(months[last_month_date.month - 1]).lower() if current_month_date.year != last_month_date.year: - cls.current_month += "_" + str(current_month_date.year) - cls.last_month += "_" + str(last_month_date.year) + self.current_month += "_" + str(current_month_date.year) + self.last_month += "_" + str(last_month_date.year) def test_issue_analytics(self): create_service_level_agreements_for_issues()