nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-04 12:49:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: autofixes by semgrep

Browse Source
This commit is contained in:
Mihir Kandoi
2026-01-01 21:56:12 +05:30
parent 767bb534c0
commit ca568a01f5
41 changed files with 294 additions and 373 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
erpnext/public/js/controllers/transaction.js
View File

@@ -904,7 +904,7 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
get_incoming_rate(item, posting_date, posting_time, voucher_type, company) {
let item_args = {
item_code: item.item_code,
warehouse: in_list("Purchase Receipt", "Purchase Invoice") ? item.from_warehouse : item.warehouse,
warehouse: item.warehouse,
posting_date: posting_date,
posting_time: posting_time,
qty: item.qty * item.conversion_factor,
@@ -2248,7 +2248,7 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
child.apply_rule_on_other_items &&
JSON.parse(child.apply_rule_on_other_items).length
) {
if (!in_list(JSON.parse(child.apply_rule_on_other_items), child.item_code)) {
if (!JSON.parse(child.apply_rule_on_other_items).includes(child.item_code)) {
continue;
}
}
@@ -2296,7 +2296,7 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
if (JSON.parse(data.apply_rule_on_other_items).includes(d[data.apply_rule_on])) {
for (var k in data) {
if (
in_list(fields, k) &&
fields.includes(k) &&
data[k] &&
(data.price_or_product_discount === "Price" || k === "pricing_rules")
) {
@@ -2768,8 +2768,7 @@ erpnext.TransactionController = class TransactionController extends erpnext.taxe
}
has_discount_in_schedule() {
let is_eligible = in_list(
["Sales Order", "Sales Invoice", "Purchase Order", "Purchase Invoice"],
let is_eligible = ["Sales Order", "Sales Invoice", "Purchase Order", "Purchase Invoice"].includes(
this.frm.doctype
);
let has_payment_schedule = this.frm.doc.payment_schedule && this.frm.doc.payment_schedule.length;
@@ -3205,16 +3204,13 @@ erpnext.show_serial_batch_selector = function (frm, item_row, callback, on_close
}
if (
in_list(
[
"Material Transfer",
"Send to Subcontractor",
"Material Issue",
"Material Consumption for Manufacture",
"Material Transfer for Manufacture",
],
frm.doc.purpose
)
[
"Material Transfer",
"Send to Subcontractor",
"Material Issue",
"Material Consumption for Manufacture",
"Material Transfer for Manufacture",
].includes(frm.doc.purpose)
) {
warehouse_field = "s_warehouse";
} else {