nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-07 07:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: validate root type as well

Browse Source
This commit is contained in:
khushi8112
2025-11-18 15:26:02 +05:30
parent 592ec1c5a5
commit ca37f0371b
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/accounts/doctype/journal_entry/journal_entry.py
View File

@@ -326,10 +326,15 @@ class JournalEntry(AccountsController):
def validate_depr_account_and_depr_entry_voucher_type(self): def validate_depr_account_and_depr_entry_voucher_type(self):
for d in self.get("accounts"): for d in self.get("accounts"):
root_type = frappe.get_cached_value("Account", d.account, "root_type")
if ( if (
d.reference_type == "Asset" d.reference_type == "Asset"
and d.reference_name and d.reference_name
and (d.account_type == "Depreciation" or self.voucher_type == "Depreciation Entry") and (
d.account_type == "Depreciation"
or self.voucher_type == "Depreciation Entry"
or root_type == "Expense"
)
and d.debit and d.debit
): ):
if d.account_type != "Depreciation": if d.account_type != "Depreciation":
@@ -340,7 +345,7 @@ class JournalEntry(AccountsController):
_("Journal Entry type should be set as Depreciation Entry for asset depreciation") _("Journal Entry type should be set as Depreciation Entry for asset depreciation")
) )
if frappe.get_cached_value("Account", d.account, "root_type") != "Expense": if root_type != "Expense":
frappe.throw(_("Account {0} should be of type Expense").format(d.account)) frappe.throw(_("Account {0} should be of type Expense").format(d.account))
def validate_stock_accounts(self): def validate_stock_accounts(self):