From c9960b4d51804b7b3d7590812e304bcd0bed9385 Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Fri, 3 Jul 2026 14:16:46 +0530 Subject: [PATCH] fix: carry bank/cash account and cost center into Payment Reconciliation --- .../process_payment_reconciliation.py | 2 ++ .../test_process_payment_reconciliation.py | 9 +++------ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/erpnext/accounts/doctype/process_payment_reconciliation/process_payment_reconciliation.py b/erpnext/accounts/doctype/process_payment_reconciliation/process_payment_reconciliation.py index 21ac42a5d3a..9c843f21486 100644 --- a/erpnext/accounts/doctype/process_payment_reconciliation/process_payment_reconciliation.py +++ b/erpnext/accounts/doctype/process_payment_reconciliation/process_payment_reconciliation.py @@ -106,6 +106,8 @@ def get_pr_instance(doc: str): "party", "receivable_payable_account", "default_advance_account", + "bank_cash_account", + "cost_center", "from_invoice_date", "to_invoice_date", "from_payment_date", diff --git a/erpnext/accounts/doctype/process_payment_reconciliation/test_process_payment_reconciliation.py b/erpnext/accounts/doctype/process_payment_reconciliation/test_process_payment_reconciliation.py index 2950677ae75..ccdaca2da1c 100644 --- a/erpnext/accounts/doctype/process_payment_reconciliation/test_process_payment_reconciliation.py +++ b/erpnext/accounts/doctype/process_payment_reconciliation/test_process_payment_reconciliation.py @@ -63,14 +63,11 @@ class TestProcessPaymentReconciliation(ERPNextTestSuite): self.assertEqual(pr.invoice_limit, 1000) self.assertEqual(pr.payment_limit, 1000) - def test_get_pr_instance_drops_bank_cash_and_cost_center_filters(self): - # SUSPECTED BUG: get_pr_instance's field list omits bank_cash_account and - # cost_center, so those filters are silently lost when the tool run is built. - # Locking the current (wrong) behaviour. + def test_get_pr_instance_copies_bank_cash_and_cost_center(self): doc = self.make_ppr(bank_cash_account="Cash - _TC") doc.cost_center = "_Test Cost Center - _TC" doc.insert() pr = get_pr_instance(doc.name) - self.assertFalse(pr.get("bank_cash_account")) - self.assertFalse(pr.get("cost_center")) + self.assertEqual(pr.bank_cash_account, "Cash - _TC") + self.assertEqual(pr.cost_center, "_Test Cost Center - _TC")