nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-08-14 23:18:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #56771 from mihir-kandoi/pg/advisory-lock-postgres-only

Browse Source 
fix: restrict repost advisory-lock gate to Postgres
This commit is contained in:
Mihir Kandoi
2026-07-02 13:27:49 +05:30
committed by GitHub
parent 0a05dd4426 99fbd61bd9
commit c98ca6d2cc
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/stock/stock_ledger.py
View File

@@ -275,10 +275,11 @@ def repost_gate(item_code, warehouse):
racing into a lock-order deadlock. Row locks still enforce correctness; this only cuts the
deadlock/retry churn. Scope is repost-vs-repost only -- the synchronous repost_current_voucher
submit path is deliberately not gated (blocking a submit behind a background repost would be a
worse regression) and keeps relying on the existing deadlock retry. No advisory locks, no gate."""
worse regression) and keeps relying on the existing deadlock retry. Postgres only: MariaDB
keeps the plain deadlock-retry path."""
# hasattr keeps this a graceful opt-in: on an ERPNext predating frappe.db.advisory_lock, fall
# back to no gate rather than raising and marking the Repost Item Valuation permanently Failed.
if frappe.db.db_type in ("postgres", "mariadb") and hasattr(frappe.db, "advisory_lock"):
if frappe.db.db_type == "postgres" and hasattr(frappe.db, "advisory_lock"):
# Tuple key: a colon in item_code/warehouse can't collide two distinct pairs onto one lock.
return frappe.db.advisory_lock(("stock_repost", item_code, warehouse), timeout=REPOST_LOCK_TIMEOUT)
return nullcontext()