From c93dba289581456ab4537454d00492ef2bedb92c Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Tue, 25 Nov 2025 12:33:51 +0530 Subject: [PATCH] fix: coderabbit suggestions --- erpnext/selling/doctype/sales_order/sales_order.js | 2 +- erpnext/selling/doctype/sales_order/sales_order.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/selling/doctype/sales_order/sales_order.js b/erpnext/selling/doctype/sales_order/sales_order.js index 5c2f3666b48..b1fc67e8d44 100644 --- a/erpnext/selling/doctype/sales_order/sales_order.js +++ b/erpnext/selling/doctype/sales_order/sales_order.js @@ -1644,7 +1644,7 @@ erpnext.selling.SalesOrderController = class SalesOrderController extends erpnex if (selected_items.some((item) => !item.supplier)) { frappe.throw({ - message: "Supplier is required for all selected Items", + message: __("Supplier is required for all selected Items"), title: __("Supplier Required"), indicator: "blue", }); diff --git a/erpnext/selling/doctype/sales_order/sales_order.py b/erpnext/selling/doctype/sales_order/sales_order.py index b3174b2bffa..adbc9839512 100755 --- a/erpnext/selling/doctype/sales_order/sales_order.py +++ b/erpnext/selling/doctype/sales_order/sales_order.py @@ -1682,7 +1682,7 @@ def make_purchase_order(source_name, selected_items=None, target_doc=None): "margin_rate_or_amount", ], "postprocess": update_item, - "condition": lambda doc: filter_items(doc, supplier), + "condition": lambda doc, s=supplier: filter_items(doc, s), }, "Packed Item": { "doctype": "Purchase Order Item",