From c6c2773e02a5b3f6d5a94079025bd642f8196127 Mon Sep 17 00:00:00 2001 From: barredterra <14891507+barredterra@users.noreply.github.com> Date: Tue, 3 Aug 2021 11:22:42 +0200 Subject: [PATCH] refactor: def instead of lambda --- erpnext/regional/report/datev/datev.py | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/erpnext/regional/report/datev/datev.py b/erpnext/regional/report/datev/datev.py index 5df24c2bb35..5dd71ea794a 100644 --- a/erpnext/regional/report/datev/datev.py +++ b/erpnext/regional/report/datev/datev.py @@ -200,6 +200,10 @@ def get_transactions(filters, as_dict=1): def run(params_method, filters): extra_fields, extra_joins, extra_filters = params_method(filters) return run_query(filters, extra_fields, extra_joins, extra_filters, as_dict=as_dict) + + def sort_by(row): + # "Belegdatum" is in the fifth column when list format is used + return row["Belegdatum" if as_dict else 5] type_map = { # specific query methods for some voucher types @@ -222,11 +226,6 @@ def get_transactions(filters, as_dict=1): filters["exclude_voucher_types"] = type_map.keys() transactions.extend(run(params_method=get_generic_params, filters=filters)) - if as_dict: - sort_by = lambda row: row["Belegdatum"] - else: - sort_by = lambda row: row[5] - return sorted(transactions, key=sort_by)