nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-25 07:54:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #30573 from frappe/mergify/bp/develop/pr-30382

Browse Source 
fix: Added validation for single_threshold in Tax With Holding Category (backport #30382)
This commit is contained in:
Saqib Ansari
2022-04-05 15:52:28 +05:30
committed by GitHub
parent 7757790572 e796267214
commit c4b5fa8ed1
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py
View File

@@ -34,7 +34,9 @@ class TaxWithholdingCategory(Document):
def validate_thresholds(self): def validate_thresholds(self):
for d in self.get("rates"): for d in self.get("rates"):
if d.cumulative_threshold and d.cumulative_threshold < d.single_threshold: if (
d.cumulative_threshold and d.single_threshold and d.cumulative_threshold < d.single_threshold
):
frappe.throw( frappe.throw(
_("Row #{0}: Cumulative threshold cannot be less than Single Transaction threshold").format( _("Row #{0}: Cumulative threshold cannot be less than Single Transaction threshold").format(
d.idx d.idx