nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-26 08:24:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #45687 from aerele/validate_equity_account

Browse Source 
fix: add validation to allow equity account
This commit is contained in:
ruthra kumar
2025-02-18 11:44:34 +05:30
committed by GitHub
parent fe47ca8566 f82837a4a2
commit c46af238d4
2 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
erpnext/accounts/doctype/gl_entry/test_gl_entry.py
View File

@@ -123,3 +123,20 @@ class TestGLEntry(IntegrationTestCase):
str(e), str(e),
"Party Type and Party can only be set for Receivable / Payable account_Test Account Cost for Goods Sold - _TC", "Party Type and Party can only be set for Receivable / Payable account_Test Account Cost for Goods Sold - _TC",
) )
def test_validate_account_party_type_shareholder(self):
jv = make_journal_entry(
"Opening Balance Equity - _TC",
"Cash - _TC",
100,
"_Test Cost Center - _TC",
save=False,
submit=False,
)
for row in jv.accounts:
row.party_type = "Shareholder"
break
jv.save().submit()
self.assertEqual(1, jv.docstatus)

2
erpnext/accounts/party.py
View File

@@ -777,7 +777,7 @@ def validate_account_party_type(self):
if self.party_type and self.party: if self.party_type and self.party:
account_type = frappe.get_cached_value("Account", self.account, "account_type") account_type = frappe.get_cached_value("Account", self.account, "account_type")
if account_type and (account_type not in ["Receivable", "Payable"]): if account_type and (account_type not in ["Receivable", "Payable", "Equity"]):
frappe.throw( frappe.throw(
_( _(
"Party Type and Party can only be set for Receivable / Payable account<br><br>" "{0}" "Party Type and Party can only be set for Receivable / Payable account<br><br>" "{0}"