nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-31 18:59:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: skip warehouse validation for non-stock items

Browse Source 
(cherry picked from commit 199a6da960)

# Conflicts:
#	erpnext/controllers/accounts_controller.py
This commit is contained in:
Saqib Ansari
2022-03-31 11:41:52 +05:30
committed by mergify-bot
parent ad91d57a41
commit c36b5d9ab8
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/controllers/accounts_controller.py
View File

@@ -1265,12 +1265,10 @@ class AccountsController(TransactionBase):
return get_company_default(self.company, fieldname, ignore_validation=ignore_validation) return get_company_default(self.company, fieldname, ignore_validation=ignore_validation)
def get_stock_items(self): def get_stock_items(self):
if hasattr(self, "_stock_items") and self._stock_items:
return self._stock_items
stock_items = [] stock_items = []
item_codes = list(set(item.item_code for item in self.get("items"))) item_codes = list(set(item.item_code for item in self.get("items")))
if item_codes: if item_codes:
<<<<<<< HEAD
stock_items = [ stock_items = [
r[0] r[0]
for r in frappe.db.sql( for r in frappe.db.sql(
@@ -1282,8 +1280,12 @@ class AccountsController(TransactionBase):
item_codes, item_codes,
) )
] ]
=======
stock_items = frappe.db.get_values(
"Item", {"name": ["in", item_codes], "is_stock_item": 1}, pluck="name", cache=True
)
>>>>>>> 199a6da960 (perf: skip warehouse validation for non-stock items)
self._stock_items = stock_items
return stock_items return stock_items
def set_total_advance_paid(self): def set_total_advance_paid(self):