nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-25 07:54:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: dont pass ignore permissions param to whitelist methods

Browse Source
This commit is contained in:
RitvikSardana
2025-04-25 15:31:02 +05:30
parent 4f690affc9
commit c28596f69d
2 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/accounts/doctype/journal_entry/journal_entry.py
View File

@@ -1235,9 +1235,7 @@ class JournalEntry(AccountsController):
@frappe.whitelist() @frappe.whitelist()
def get_default_bank_cash_account( def get_default_bank_cash_account(company, account_type=None, mode_of_payment=None, account=None):
company, account_type=None, mode_of_payment=None, account=None, ignore_permissions=False
):
from erpnext.accounts.doctype.sales_invoice.sales_invoice import get_bank_cash_account from erpnext.accounts.doctype.sales_invoice.sales_invoice import get_bank_cash_account
if mode_of_payment: if mode_of_payment:
@@ -1275,7 +1273,7 @@ def get_default_bank_cash_account(
return frappe._dict( return frappe._dict(
{ {
"account": account, "account": account,
"balance": get_balance_on(account, ignore_account_permission=ignore_permissions), "balance": get_balance_on(account),
"account_currency": account_details.account_currency, "account_currency": account_details.account_currency,
"account_type": account_details.account_type, "account_type": account_details.account_type,
} }

8
erpnext/accounts/doctype/payment_entry/payment_entry.py
View File

@@ -2848,7 +2848,6 @@ def get_payment_entry(
party_type=None, party_type=None,
payment_type=None, payment_type=None,
reference_date=None, reference_date=None,
ignore_permissions=False,
created_from_payment_request=False, created_from_payment_request=False,
): ):
doc = frappe.get_doc(dt, dn) doc = frappe.get_doc(dt, dn)
@@ -2870,14 +2869,14 @@ def get_payment_entry(
) )
# bank or cash # bank or cash
bank = get_bank_cash_account(doc, bank_account, ignore_permissions=ignore_permissions) bank = get_bank_cash_account(doc, bank_account)
# if default bank or cash account is not set in company master and party has default company bank account, fetch it # if default bank or cash account is not set in company master and party has default company bank account, fetch it
if party_type in ["Customer", "Supplier"] and not bank: if party_type in ["Customer", "Supplier"] and not bank:
party_bank_account = get_party_bank_account(party_type, doc.get(scrub(party_type))) party_bank_account = get_party_bank_account(party_type, doc.get(scrub(party_type)))
if party_bank_account: if party_bank_account:
account = frappe.db.get_value("Bank Account", party_bank_account, "account") account = frappe.db.get_value("Bank Account", party_bank_account, "account")
bank = get_bank_cash_account(doc, account, ignore_permissions=ignore_permissions) bank = get_bank_cash_account(doc, account)
paid_amount, received_amount = set_paid_amount_and_received_amount( paid_amount, received_amount = set_paid_amount_and_received_amount(
dt, party_account_currency, bank, outstanding_amount, payment_type, bank_amount, doc dt, party_account_currency, bank, outstanding_amount, payment_type, bank_amount, doc
@@ -3183,13 +3182,12 @@ def update_accounting_dimensions(pe, doc):
pe.set(dimension, doc.get(dimension)) pe.set(dimension, doc.get(dimension))
def get_bank_cash_account(doc, bank_account, ignore_permissions=False): def get_bank_cash_account(doc, bank_account):
bank = get_default_bank_cash_account( bank = get_default_bank_cash_account(
doc.company, doc.company,
"Bank", "Bank",
mode_of_payment=doc.get("mode_of_payment"), mode_of_payment=doc.get("mode_of_payment"),
account=bank_account, account=bank_account,
ignore_permissions=ignore_permissions,
) )
if not bank: if not bank: