nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-21 05:59:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: replace get_doc with get_lazy_doc for asset retrieval and optimize stock entry fetching

Browse Source
This commit is contained in:
ljain112
2025-11-28 18:54:37 +05:30
parent 00ffdee928
commit c2810ea799
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
erpnext/assets/doctype/asset_repair/asset_repair.py
View File

@@ -57,7 +57,7 @@ class AssetRepair(AccountsController):
# end: auto-generated types # end: auto-generated types
def validate(self): def validate(self):
self.asset_doc = frappe.get_doc("Asset", self.asset) self.asset_doc = frappe.get_lazy_doc("Asset", self.asset)
self.validate_asset() self.validate_asset()
self.validate_dates() self.validate_dates()
self.validate_purchase_invoices() self.validate_purchase_invoices()
@@ -188,7 +188,7 @@ class AssetRepair(AccountsController):
self.cancel_sabb() self.cancel_sabb()
def after_delete(self): def after_delete(self):
frappe.get_doc("Asset", self.asset).set_status() frappe.get_lazy_doc("Asset", self.asset).set_status()
def check_repair_status(self): def check_repair_status(self):
if self.repair_status == "Pending" and self.docstatus == 1: if self.repair_status == "Pending" and self.docstatus == 1:
@@ -324,7 +324,10 @@ class AssetRepair(AccountsController):
return return
# creating GL Entries for each row in Stock Items based on the Stock Entry created for it # creating GL Entries for each row in Stock Items based on the Stock Entry created for it
stock_entry = frappe.get_doc("Stock Entry", {"asset_repair": self.name}) stock_entry_name = frappe.db.get_value("Stock Entry", {"asset_repair": self.name}, "name")
stock_entry_items = frappe.get_all(
"Stock Entry Detail", filters={"parent": stock_entry_name}, fields=["expense_account", "amount"]
)
default_expense_account = None default_expense_account = None
if not erpnext.is_perpetual_inventory_enabled(self.company): if not erpnext.is_perpetual_inventory_enabled(self.company):
@@ -334,7 +337,7 @@ class AssetRepair(AccountsController):
if not default_expense_account: if not default_expense_account:
frappe.throw(_("Please set default Expense Account in Company {0}").format(self.company)) frappe.throw(_("Please set default Expense Account in Company {0}").format(self.company))
for item in stock_entry.items: for item in stock_entry_items:
if flt(item.amount) > 0: if flt(item.amount) > 0:
gl_entries.append( gl_entries.append(
self.get_gl_dict( self.get_gl_dict(
@@ -365,7 +368,7 @@ class AssetRepair(AccountsController):
"cost_center": self.cost_center, "cost_center": self.cost_center,
"posting_date": self.completion_date, "posting_date": self.completion_date,
"against_voucher_type": "Stock Entry", "against_voucher_type": "Stock Entry",
"against_voucher": stock_entry.name, "against_voucher": stock_entry_name,
"company": self.company, "company": self.company,
}, },
item=self, item=self,