From 39fc5179f962c0ff2a670495404d40bf7957d6cb Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Tue, 19 Feb 2013 15:47:19 +0530 Subject: [PATCH 1/5] display customer name instead of customer id in quotation print format --- selling/Print Format/Quotation Classic/Quotation Classic.txt | 4 ++-- selling/Print Format/Quotation Modern/Quotation Modern.txt | 4 ++-- selling/Print Format/Quotation Spartan/Quotation Spartan.txt | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/selling/Print Format/Quotation Classic/Quotation Classic.txt b/selling/Print Format/Quotation Classic/Quotation Classic.txt index 885570ecf27..ca950a21ad6 100644 --- a/selling/Print Format/Quotation Classic/Quotation Classic.txt +++ b/selling/Print Format/Quotation Classic/Quotation Classic.txt @@ -2,14 +2,14 @@ { "creation": "2012-04-17 11:29:12", "docstatus": 0, - "modified": "2013-01-25 17:11:54", + "modified": "2013-02-19 15:44:56", "modified_by": "Administrator", "owner": "Administrator" }, { "doc_type": "Quotation", "doctype": "Print Format", - "html": "\n\n\n\n\n\n\n\n\n\n\n\n
\n\t\n\t\n
\n\n", + "html": "\n\n\n\n\n\n\n\n\n\n\n\n
\n\t\n\t\n
\n\n", "module": "Selling", "name": "__common__", "standard": "Yes" diff --git a/selling/Print Format/Quotation Modern/Quotation Modern.txt b/selling/Print Format/Quotation Modern/Quotation Modern.txt index 707d5ead931..a323fbf8292 100644 --- a/selling/Print Format/Quotation Modern/Quotation Modern.txt +++ b/selling/Print Format/Quotation Modern/Quotation Modern.txt @@ -2,14 +2,14 @@ { "creation": "2012-04-17 11:29:12", "docstatus": 0, - "modified": "2013-01-25 17:15:42", + "modified": "2013-02-19 15:44:22", "modified_by": "Administrator", "owner": "Administrator" }, { "doc_type": "Quotation", "doctype": "Print Format", - "html": "\n\n\n\n\n\n\n\n\n\n\n\n
\n\t\n\t\n
\n\n", + "html": "\n\n\n\n\n\n\n\n\n\n\n\n
\n\t\n\t\n
\n\n", "module": "Selling", "name": "__common__", "standard": "Yes" diff --git a/selling/Print Format/Quotation Spartan/Quotation Spartan.txt b/selling/Print Format/Quotation Spartan/Quotation Spartan.txt index f49e4c99208..d2e04dda8d6 100644 --- a/selling/Print Format/Quotation Spartan/Quotation Spartan.txt +++ b/selling/Print Format/Quotation Spartan/Quotation Spartan.txt @@ -2,14 +2,14 @@ { "creation": "2012-04-17 11:29:12", "docstatus": 0, - "modified": "2013-01-25 17:09:04", + "modified": "2013-02-19 15:45:22", "modified_by": "Administrator", "owner": "Administrator" }, { "doc_type": "Quotation", "doctype": "Print Format", - "html": "\n\n\n\n\n\n\n\n\n\n\n\n
\n\t\n\t\n
\n\n", + "html": "\n\n\n\n\n\n\n\n\n\n\n\n
\n\t\n\t\n
\n\n", "module": "Selling", "name": "__common__", "standard": "Yes" From f2d68e2fd568ee85933da0cda71cbdbf2de39e0b Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Tue, 19 Feb 2013 15:55:11 +0530 Subject: [PATCH 2/5] display customer name instead of customer id in quotation print format --- patches/patch_list.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/patches/patch_list.py b/patches/patch_list.py index d42360ef067..770eff0cf8d 100644 --- a/patches/patch_list.py +++ b/patches/patch_list.py @@ -175,4 +175,7 @@ patch_list = [ "patches.february_2013.p05_leave_application", "patches.february_2013.gle_floating_point_issue_revisited", "patches.february_2013.fix_outstanding", + 'execute:webnotes.reload_doc([["selling", "Print Format", "Quotation Classic"], \ + ["selling", "Print Format", "Quotation Modern"], \ + ["selling", "Print Format", "Quotation Spartan"]]) # 2013-02-19', ] \ No newline at end of file From 0e5ea316cc696c0c6ab555b95cb4705a4707701d Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Tue, 19 Feb 2013 16:14:27 +0530 Subject: [PATCH 3/5] fixes in naming series --- setup/doctype/naming_series/naming_series.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/setup/doctype/naming_series/naming_series.py b/setup/doctype/naming_series/naming_series.py index dbbc298c4c8..599118152d5 100644 --- a/setup/doctype/naming_series/naming_series.py +++ b/setup/doctype/naming_series/naming_series.py @@ -101,15 +101,19 @@ class DocType: from core.doctype.doctype.doctype import DocType dt = DocType() - parent = sql("select parent from `tabDocField` where fieldname='naming_series' and parent != %s", self.doc.select_doc_for_series) - sr = ([webnotes.model.doctype.get_property(p[0], 'options', 'naming_series'), p[0]] for p in parent) + parent = sql("""select dt.name from `tabDocField` df, `tabDocType` dt + where dt.name = df.parent and df.fieldname='naming_series' and dt.name != %s""", + self.doc.select_doc_for_series) + sr = ([webnotes.model.doctype.get_property(p[0], 'options', 'naming_series'), p[0]] + for p in parent) options = self.scrub_options_list(self.doc.set_options.split("\n")) for series in options: dt.validate_series(series, self.doc.select_doc_for_series) for i in sr: if i[0]: if series in i[0].split("\n"): - msgprint("Oops! Series name %s is already in use in %s. Please select a new one" % (series, i[1]), raise_exception=1) + msgprint("Oops! Series name %s is already in use in %s. \ + Please select a new one" % (series, i[1]), raise_exception=1) def validate_series_name(self, n): import re From 452de98a6cbd0929e71c3204dacc5d2de2f3814c Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Tue, 19 Feb 2013 16:18:00 +0530 Subject: [PATCH 4/5] fixes in patch_list --- patches/patch_list.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/patches/patch_list.py b/patches/patch_list.py index 770eff0cf8d..538a0fd1ea7 100644 --- a/patches/patch_list.py +++ b/patches/patch_list.py @@ -175,7 +175,7 @@ patch_list = [ "patches.february_2013.p05_leave_application", "patches.february_2013.gle_floating_point_issue_revisited", "patches.february_2013.fix_outstanding", - 'execute:webnotes.reload_doc([["selling", "Print Format", "Quotation Classic"], \ - ["selling", "Print Format", "Quotation Modern"], \ - ["selling", "Print Format", "Quotation Spartan"]]) # 2013-02-19', + 'execute:webnotes.reload_doc("selling", "Print Format", "Quotation Classic") # 2013-02-19', + 'execute:webnotes.reload_doc("selling", "Print Format", "Quotation Modern") # 2013-02-19', + 'execute:webnotes.reload_doc("selling", "Print Format", "Quotation Spartan") # 2013-02-19', ] \ No newline at end of file From 704d5f0f4ac61982480371be96034bcab256d2de Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Tue, 19 Feb 2013 16:23:21 +0530 Subject: [PATCH 5/5] delete service order/quotation doctype --- patches/patch_list.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/patches/patch_list.py b/patches/patch_list.py index 538a0fd1ea7..ab9130ebe62 100644 --- a/patches/patch_list.py +++ b/patches/patch_list.py @@ -178,4 +178,8 @@ patch_list = [ 'execute:webnotes.reload_doc("selling", "Print Format", "Quotation Classic") # 2013-02-19', 'execute:webnotes.reload_doc("selling", "Print Format", "Quotation Modern") # 2013-02-19', 'execute:webnotes.reload_doc("selling", "Print Format", "Quotation Spartan") # 2013-02-19', + "execute:webnotes.delete_doc('DocType', 'Service Order')", + "execute:webnotes.delete_doc('DocType', 'Service Quotation')", + "execute:webnotes.delete_doc('DocType', 'Service Order Detail')", + "execute:webnotes.delete_doc('DocType', 'Service Quotation Detail')", ] \ No newline at end of file