From c0668809786211fdf62b9d12eb7d7137b6394af1 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Mon, 22 Jun 2026 15:53:52 +0530 Subject: [PATCH] fix: address product bundle review comments (cherry picked from commit d48a1e0d1698bb1fcba38584ba4623f9acddba9e) --- .../stock/report/item_where_used/item_where_used.py | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/erpnext/stock/report/item_where_used/item_where_used.py b/erpnext/stock/report/item_where_used/item_where_used.py index 6f95bd51463..4fecf71b35b 100644 --- a/erpnext/stock/report/item_where_used/item_where_used.py +++ b/erpnext/stock/report/item_where_used/item_where_used.py @@ -479,18 +479,23 @@ def hide_empty_optional_columns(columns, data): fields_with_values = set() for row in data: - for fieldname in optional_fields: - if field_has_value(row, fieldname): - fields_with_values.add(fieldname) + for column in columns: + fieldname = column["fieldname"] + if fieldname in optional_fields and field_has_value(row, column): + fields_with_values.add(column["fieldname"]) return [column for column in columns if column["fieldname"] not in optional_fields - fields_with_values] -def field_has_value(row, fieldname): +def field_has_value(row, column): + fieldname = column["fieldname"] if fieldname not in row: return False value = row.get(fieldname) + if column.get("fieldtype") == "Check": + return bool(value) + return value is not None and value != ""