From beaf13e00ed638abeae9d4489f91de9d96a9dd8a Mon Sep 17 00:00:00 2001 From: Rucha Mahabal Date: Tue, 11 Jul 2023 14:12:21 +0530 Subject: [PATCH] fix(Employee Advance): check if return amount is set before validating (#36080) --- erpnext/hr/doctype/employee_advance/employee_advance.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/hr/doctype/employee_advance/employee_advance.py b/erpnext/hr/doctype/employee_advance/employee_advance.py index c1876b11757..44bebb78c40 100644 --- a/erpnext/hr/doctype/employee_advance/employee_advance.py +++ b/erpnext/hr/doctype/employee_advance/employee_advance.py @@ -108,8 +108,8 @@ class EmployeeAdvance(Document): EmployeeAdvanceOverPayment, ) - if flt(return_amount) > self.paid_amount - self.claimed_amount: - frappe.throw(_("Return amount cannot be greater unclaimed amount")) + if flt(return_amount) > 0 and flt(return_amount) > (self.paid_amount - self.claimed_amount): + frappe.throw(_("Return amount cannot be greater than unclaimed amount")) self.db_set("paid_amount", paid_amount) self.db_set("return_amount", return_amount)