mirror of
https://github.com/frappe/erpnext.git
synced 2026-05-13 10:11:20 +00:00
ci: semgrep to prevent test regression
This commit is contained in:
18
semgrep/test-correctness.yml
Normal file
18
semgrep/test-correctness.yml
Normal file
@@ -0,0 +1,18 @@
|
||||
rules:
|
||||
- id: Dont-commit
|
||||
pattern: frappe.db.commit()
|
||||
message: Commiting inside test breaks idempotency.
|
||||
languages: [python]
|
||||
severity: ERROR
|
||||
- id: Implicit-commit
|
||||
pattern: frappe.db.truncate()
|
||||
message: DB truncation does implict commit which breaks test idempotency.
|
||||
languages: [python]
|
||||
severity: ERROR
|
||||
- id: Dont-override-teardown
|
||||
pattern: |
|
||||
def tearDown(...):
|
||||
...
|
||||
message: ERPNextTestSuite forces rollback on each tearDown, which ensures idempotency. Don't override tearDown.
|
||||
languages: [python]
|
||||
severity: ERROR
|
||||
Reference in New Issue
Block a user