nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-06 06:58:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: replace get_doc with sql

Browse Source
This commit is contained in:
ruthra kumar
2024-12-20 16:02:29 +05:30
parent 63dae6bd42
commit bd42d09592
1 changed files with 39 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

54
erpnext/controllers/budget_controller.py
View File

@@ -1,4 +1,5 @@
import frappe import frappe
from frappe import qb
# from erpnext.accounts.doctype.accounting_dimension.accounting_dimension import get_dimensions # from erpnext.accounts.doctype.accounting_dimension.accounting_dimension import get_dimensions
from erpnext.accounts.utils import get_fiscal_year from erpnext.accounts.utils import get_fiscal_year
@@ -28,24 +29,48 @@ class BudgetValidation:
) )
def get_budget_records(self): def get_budget_records(self):
self.budgets = [] bud = qb.DocType("Budget")
for x in frappe.db.get_all( bud_acc = qb.DocType("Budget Account")
"Budget", {"fiscal_year": self.fiscal_year, "docstatus": 1, "company": self.company} query = (
): qb.from_(bud)
self.budgets.append(frappe.get_doc("Budget", x.name)) .inner_join(bud_acc)
.on(bud.name == bud_acc.parent)
.select(
bud.name,
bud.budget_against,
bud.company,
bud.applicable_on_material_request,
bud.action_if_annual_budget_exceeded_on_mr,
bud.action_if_accumulated_monthly_budget_exceeded_on_mr,
bud.applicable_on_purchase_order,
bud.action_if_annual_budget_exceeded_on_po,
bud.action_if_accumulated_monthly_budget_exceeded_on_po,
bud.applicable_on_booking_actual_expenses,
bud.action_if_annual_budget_exceeded,
bud.action_if_accumulated_monthly_budget_exceeded,
bud_acc.account,
bud_acc.budget_amount,
)
.where(bud.docstatus.eq(1) & bud.fiscal_year.eq(self.fiscal_year) & bud.company.eq(self.company))
)
# add dimension fields
for x in self.dimensions:
query = query.select(bud[x.get("fieldname")])
self.budgets = query.run(as_dict=True)
def generate_active_budget_keys(self): def generate_active_budget_keys(self):
""" """
key structure - (dimension_type, dimension, GL account) key structure - (dimension_type, dimension, GL account)
""" """
self.active_keys = set()
self.get_budget_records() self.get_budget_records()
_keys = []
for x in self.budgets: for x in self.budgets:
budget_against = frappe.scrub(x.budget_against) budget_against = frappe.scrub(x.budget_against)
dimension = x.get(budget_against) dimension = x.get(budget_against)
self.active_keys = self.active_keys | set( _keys.append((budget_against, dimension, x.account))
[(budget_against, dimension, acc.account) for acc in x.accounts] self.active_keys = set(_keys)
)
def generate_doc_dimension_keys(self): def generate_doc_dimension_keys(self):
""" """
@@ -68,12 +93,11 @@ class BudgetValidation:
for x in self.budgets: for x in self.budgets:
budget_against = frappe.scrub(x.budget_against) budget_against = frappe.scrub(x.budget_against)
dimension = x.get(budget_against) dimension = x.get(budget_against)
for acc in x.accounts: key = (budget_against, dimension, x.account)
key = (budget_against, dimension, acc.account) if key in self.overlap:
if key in self.overlap: self.budget_map[key] = frappe._dict(
self.budget_map[key] = frappe._dict( {"budget_amount": x.budget_amount, "items_to_process": []}
{"budget_amount": acc.budget_amount, "items_to_process": []} )
)
for itm in self.doc.items: for itm in self.doc.items:
for dim in self.dimensions: for dim in self.dimensions: