nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-15 18:01:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #56234 from mihir-kandoi/pg-stock-index-tests

Browse Source 
test(stock): make Bin/Item index tests Postgres-valid (SHOW INDEX → db-agnostic helpers)
This commit is contained in:
Mihir Kandoi
2026-06-21 10:53:48 +05:30
committed by GitHub
parent 851e70b0f3 9fe2202f39
commit bc9503bdbf
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/stock/doctype/bin/test_bin.py
View File

@@ -27,6 +27,6 @@ class TestBin(ERPNextTestSuite):
self.assertEqual(bin.item_code, item_code) self.assertEqual(bin.item_code, item_code)
def test_index_exists(self): def test_index_exists(self):
indexes = frappe.db.sql("show index from tabBin where Non_unique = 0", as_dict=1) # has_index is db-agnostic; raw "SHOW INDEX" is MySQL-only and errors on Postgres
if not any(index.get("Key_name") == "unique_item_warehouse" for index in indexes): if not frappe.db.has_index("tabBin", "unique_item_warehouse"):
self.fail("Expected unique index on item-warehouse") self.fail("Expected unique index on item-warehouse")

9
erpnext/stock/doctype/item/test_item.py
View File

@@ -778,10 +778,13 @@ class TestItem(ERPNextTestSuite):
def test_index_creation(self): def test_index_creation(self):
"check if index is getting created in db" "check if index is getting created in db"
indices = frappe.db.sql("show index from tabItem", as_dict=1) # get_column_index is db-agnostic; raw "SHOW INDEX" is MySQL-only and errors on Postgres
expected_columns = {"item_code", "item_name", "item_group"} expected_columns = {"item_code", "item_name", "item_group"}
for index in indices: for column in list(expected_columns):
expected_columns.discard(index.get("Column_name")) if frappe.db.get_column_index("tabItem", column, unique=False) or frappe.db.get_column_index(
"tabItem", column, unique=True
):
expected_columns.discard(column)
if expected_columns: if expected_columns:
self.fail(f"Expected db index on these columns: {', '.join(expected_columns)}") self.fail(f"Expected db index on these columns: {', '.join(expected_columns)}")