diff --git a/accounts/page/voucher_import_tool/voucher_import_tool.py b/accounts/page/voucher_import_tool/voucher_import_tool.py index 529f6fcebb6..41d0a9f4741 100644 --- a/accounts/page/voucher_import_tool/voucher_import_tool.py +++ b/accounts/page/voucher_import_tool/voucher_import_tool.py @@ -206,7 +206,7 @@ def get_data(rows, company_abbr): if accounts: total_debit = total_credit = 0 for acc_idx in xrange(len(accounts)): - col_idx = len(columns) - 1 + acc_idx + col_idx = len(columns) + acc_idx if flt(r[col_idx]) != 0: if not acc_dict.get(accounts[acc_idx]): acc_dict[accounts[acc_idx]] = 0 @@ -215,7 +215,7 @@ def get_data(rows, company_abbr): total_debit += flt(r[col_idx]) else: total_credit += abs(flt(r[col_idx])) - + d['total_debit'] = total_debit d['total_credit'] = total_credit @@ -227,5 +227,9 @@ def get_data(rows, company_abbr): columns = [c.replace(" ", "_").lower() for c in rows[i+1] if not c.endswith(" - " + company_abbr)] accounts = [c for c in rows[i+1] if c.endswith(" - " + company_abbr)] - + + if accounts and (len(columns) != rows[i+1].index(accounts[0])): + raise Exception, """A non-account column cannot be after an account \ + column. Please rectify it in the file and try again.""" + return data, start_row_idx \ No newline at end of file diff --git a/hr/doctype/appraisal/appraisal.js b/hr/doctype/appraisal/appraisal.js index 11fa328e206..f098b802c2b 100644 --- a/hr/doctype/appraisal/appraisal.js +++ b/hr/doctype/appraisal/appraisal.js @@ -20,8 +20,9 @@ cur_frm.add_fetch('employee', 'employee_name', 'employee_name'); cur_frm.cscript.onload = function(doc,cdt,cdn){ if(!doc.status) set_multiple(cdt,cdn,{status:'Draft'}); - if(doc.amended_from && doc.__islocal) - cur_frm.cscript.refresh_appraisal_details(doc, cdt, cdn); + if(doc.amended_from && doc.__islocal) { + doc.status = "Draft"; + } } cur_frm.cscript.onload_post_render = function(doc,cdt,cdn){ @@ -42,17 +43,6 @@ cur_frm.cscript.kra_template = function(doc, dt, dn) { }); } - -cur_frm.cscript.refresh_appraisal_details = function(doc, cdt, cdn){ - var val = getchildren('Appraisal Goal', doc.name, 'appraisal_details', doc.doctype); - for(var i = 0; i