Merge branch 'v12-pre-release' into version-12

erpnext/__init__.py

@@ -5,7 +5,7 @@ import frappe
 from erpnext.hooks import regional_overrides
 from frappe.utils import getdate
 
-__version__ = '12.26.0'
+__version__ = '12.27.0'
 
 def get_default_company(user=None):
 	'''Get default company for user'''

erpnext/accounts/doctype/bank_transaction/bank_transaction.json

@@ -271,6 +271,7 @@
    "label": "Debit",
    "length": 0,
    "no_copy": 0,
+   "options": "currency",
    "permlevel": 0,
    "precision": "",
    "print_hide": 0,
@@ -304,6 +305,7 @@
    "label": "Credit",
    "length": 0,
    "no_copy": 0,
+   "options": "currency",
    "permlevel": 0,
    "precision": "",
    "print_hide": 0,
@@ -632,6 +634,7 @@
    "label": "Allocated Amount",
    "length": 0,
    "no_copy": 0,
+   "options": "currency",
    "permlevel": 0,
    "precision": "",
    "print_hide": 0,
@@ -731,6 +734,7 @@
    "label": "Unallocated Amount",
    "length": 0,
    "no_copy": 0,
+   "options": "currency",
    "permlevel": 0,
    "precision": "",
    "print_hide": 0,
@@ -755,7 +759,7 @@
  "issingle": 0,
  "istable": 0,
  "max_attachments": 0,
- "modified": "2019-05-11 05:27:55.244721",
+ "modified": "2021-11-26 12:44:55.244721",
  "modified_by": "Administrator",
  "module": "Accounts",
  "name": "Bank Transaction",

erpnext/accounts/doctype/fiscal_year/test_records.json

@@ -59,6 +59,12 @@
   "year_end_date": "2021-12-31",
   "year_start_date": "2021-01-01"
  },
+ {
+    "doctype": "Fiscal Year",
+    "year": "_Test Fiscal Year 2022",
+    "year_end_date": "2022-12-31",
+    "year_start_date": "2022-01-01"
+   },
  {
   "doctype": "Fiscal Year",
   "year": "_Test Short Fiscal Year 2021",

erpnext/change_log/v12/v12_27_0.md

@@ -0,0 +1,9 @@
+## ERPNext Version 12.27.0 Release Notes
+
+### Fixes & Enhancements
+- Always expect signature in webhook requests for WooCommerce ([#28367](https://github.com/frappe/erpnext/pull/28367))
+- Debit & Credit currency in bank transaction ([#28574](https://github.com/frappe/erpnext/pull/28574))
+- Incorrect balance in "Warehouse Wise Item Balance and Age" report ([#28583](https://github.com/frappe/erpnext/pull/28583))
+- Check if gst_category exists while validating GSTIN ([#28065](https://github.com/frappe/erpnext/pull/28065))
+- Skip empty rows while updating unsaved BOM cost ([#28136](https://github.com/frappe/erpnext/pull/28136))
+- Remove warehouse filter on Batch field for Material Receipt ([#28195](https://github.com/frappe/erpnext/pull/28195))

erpnext/erpnext_integrations/connectors/woocommerce_connection.py

@@ -14,8 +14,7 @@ def verify_request():
 	)
 
 	if frappe.request.data and \
-		frappe.get_request_header("X-Wc-Webhook-Signature") and \
+		not sig == frappe.get_request_header("X-Wc-Webhook-Signature", "").encode():
-		not sig == bytes(frappe.get_request_header("X-Wc-Webhook-Signature").encode()):
 			frappe.throw(_("Unverified Webhook Data"))
 	frappe.set_user(woocommerce_settings.creation_user)
 

erpnext/erpnext_integrations/doctype/shopify_log/shopify_log.py

@@ -64,5 +64,8 @@ def dump_request_data(data, event="create/order"):
 @frappe.whitelist()
 def resync(method, name, request_data):
 	frappe.db.set_value("Shopify Log", name, "status", "Queued", update_modified=False)
+	if not method.startswith("erpnext.erpnext_integrations.connectors.shopify_connection"):
+		return
+
 	frappe.enqueue(method=method, queue='short', timeout=300, is_async=True,
 		**{"order": json.loads(request_data), "request_id": name})

erpnext/erpnext_integrations/utils.py

@@ -18,7 +18,6 @@ def validate_webhooks_request(doctype,  hmac_key, secret_key='secret'):
 			)
 
 			if frappe.request.data and \
-				frappe.get_request_header(hmac_key) and \
 				not sig == bytes(frappe.get_request_header(hmac_key).encode()):
 					frappe.throw(_("Unverified Webhook Data"))
 			frappe.set_user(settings.modified_by)

erpnext/manufacturing/doctype/bom/bom.py

@@ -240,6 +240,9 @@ class BOM(WebsiteGenerator):
 		existing_bom_cost = self.total_cost
 
 		for d in self.get("items"):
+			if not d.item_code:
+				continue
+
 			rate = self.get_rm_rate({
 				"company": self.company,
 				"item_code": d.item_code,
@@ -549,7 +552,7 @@ class BOM(WebsiteGenerator):
 		for d in self.get('items'):
 			if d.bom_no:
 				self.get_child_exploded_items(d.bom_no, d.stock_qty)
-			else:
+			elif d.item_code:
 				self.add_to_cur_exploded_items(frappe._dict({
 					'item_code'		: d.item_code,
 					'item_name'		: d.item_name,

erpnext/manufacturing/report/bom_stock_calculated/bom_stock_calculated.py

@@ -88,7 +88,7 @@ def get_bom_stock(filters):
 			GROUP BY bom_item.item_code""".format(qty_field=qty_field, table=table, conditions=conditions, bom=bom), as_dict=1)
 
 def get_manufacturer_records():
-	details = frappe.get_list('Item Manufacturer', fields = ["manufacturer", "manufacturer_part_no", "parent"])
+	details = frappe.get_all('Item Manufacturer', fields = ["manufacturer", "manufacturer_part_no", "parent"])
 	manufacture_details = frappe._dict()
 	for detail in details:
 		dic = manufacture_details.setdefault(detail.get('parent'), {})

erpnext/regional/india/utils.py

@@ -30,12 +30,13 @@ def validate_gstin_for_india(doc, method):
 
 	gst_category = []
 
-	if len(doc.links):
+	if hasattr(doc, 'gst_category'):
-		link_doctype = doc.links[0].get("link_doctype")
+		if len(doc.links):
-		link_name = doc.links[0].get("link_name")
+			link_doctype = doc.links[0].get("link_doctype")
+			link_name = doc.links[0].get("link_name")
 
-		if link_doctype in ["Customer", "Supplier"]:
+			if link_doctype in ["Customer", "Supplier"]:
-			gst_category = frappe.db.get_value(link_doctype, {'name': link_name}, ['gst_category'])
+				gst_category = frappe.db.get_value(link_doctype, {'name': link_name}, ['gst_category'])
 
 	doc.gstin = doc.gstin.upper().strip()
 	if not doc.gstin or doc.gstin == 'NA':
@@ -66,12 +67,11 @@ def validate_tax_category(doc, method):
 			frappe.throw(_("Intra State tax category for GST State {0} already exists").format(doc.gst_state))
 
 def update_gst_category(doc, method):
-	for link in doc.links:
+	if hasattr(doc, 'gst_category'):
-		if link.link_doctype in ['Customer', 'Supplier']:
+		for link in doc.links:
-			if doc.get('gstin'):
+			if link.link_doctype in ['Customer', 'Supplier']:
-				frappe.db.sql("""
+				if doc.get('gstin'):
-					UPDATE `tab{0}` SET gst_category = %s WHERE name = %s AND gst_category = 'Unregistered'
+					frappe.db.set_value(link.link_doctype, {'name': link.link_name, 'gst_category': 'Unregistered'}, 'gst_category', 'Registered Regular')
-				""".format(link.link_doctype), ("Registered Regular", link.link_name)) #nosec
 
 def set_gst_state_and_state_number(doc):
 	if not doc.gst_state:

erpnext/regional/report/eway_bill/eway_bill.py

@@ -104,14 +104,14 @@ def set_address_details(row, special_characters):
 		row.update({'ship_to_state': row.to_state})
 
 def set_taxes(row, filters):
-	taxes = frappe.get_list("Sales Taxes and Charges",
+	taxes = frappe.get_all("Sales Taxes and Charges",
 				filters={
 					'parent': row.dn_id
 				},
 				fields=('item_wise_tax_detail', 'account_head'))
 
 	account_list = ["cgst_account", "sgst_account", "igst_account", "cess_account"]
-	taxes_list = frappe.get_list("GST Account",
+	taxes_list = frappe.get_all("GST Account",
 		filters={
 			"parent": "GST Settings",
 			"company": filters.company

erpnext/shopping_cart/cart.py

@@ -175,7 +175,9 @@ def add_new_address(doc):
 def create_lead_for_item_inquiry(lead, subject, message):
 	lead = frappe.parse_json(lead)
 	lead_doc = frappe.new_doc('Lead')
-	lead_doc.update(lead)
+	for fieldname in ("lead_name", "company_name", "email_id", "phone"):
+		lead_doc.set(fieldname, lead.get(fieldname))
+
 	lead_doc.set('lead_owner', '')
 
 	try:

erpnext/stock/doctype/item/item.py

@@ -206,10 +206,11 @@ class Item(WebsiteGenerator):
 					'route')) + '/' + self.scrub((self.item_name if self.item_name else self.item_code) + '-' + random_string(5))
 
 	def validate_website_image(self):
+		"""Validate if the website image is a public file"""
+
 		if frappe.flags.in_import:
 			return
 
-		"""Validate if the website image is a public file"""
 		auto_set_website_image = False
 		if not self.website_image and self.image:
 			auto_set_website_image = True
@@ -239,10 +240,11 @@ class Item(WebsiteGenerator):
 			self.website_image = None
 
 	def make_thumbnail(self):
+		"""Make a thumbnail of `website_image`"""
+
 		if frappe.flags.in_import:
 			return
 
-		"""Make a thumbnail of `website_image`"""
 		import requests.exceptions
 
 		if not self.is_new() and self.website_image != frappe.db.get_value(self.doctype, self.name, "website_image"):

erpnext/stock/doctype/item/test_item.py

@@ -468,7 +468,7 @@ class TestItem(unittest.TestCase):
 			item_doc.save()
 
 		# Check values saved correctly
-		barcodes = frappe.get_list(
+		barcodes = frappe.get_all(
 			'Item Barcode',
 			fields=['barcode', 'barcode_type'],
 			filters={'parent': item_code})

erpnext/stock/doctype/stock_entry/stock_entry.js

@@ -78,7 +78,11 @@ frappe.ui.form.on('Stock Entry', {
 					}
 				}
 
-				filters["warehouse"] = item.s_warehouse || item.t_warehouse;
+				// User could want to select a manually created empty batch (no warehouse)
+				// or a pre-existing batch
+				if (frm.doc.purpose != "Material Receipt") {
+					filters["warehouse"] = item.s_warehouse || item.t_warehouse;
+				}
 
 				return {
 					query : "erpnext.controllers.queries.get_batch_no",

erpnext/stock/report/warehouse_wise_item_balance_age_and_value/warehouse_wise_item_balance_age_and_value.py

@@ -39,8 +39,8 @@ def execute(filters=None):
 		item_balance.setdefault((item, item_map[item]["item_group"]), [])
 		total_stock_value = 0.00
 		for wh in warehouse_list:
-			row += [qty_dict.bal_qty] if wh.name in warehouse else [0.00]
+			row += [qty_dict.bal_qty] if wh.name == warehouse else [0.00]
-			total_stock_value += qty_dict.bal_val if wh.name in warehouse else 0.00
+			total_stock_value += qty_dict.bal_val if wh.name == warehouse else 0.00
 
 		item_balance[(item, item_map[item]["item_group"])].append(row)
 		item_value.setdefault((item, item_map[item]["item_group"]),[])

requirements.txt

@@ -7,5 +7,4 @@ plaid-python~=7.2.1
 PyGithub==1.44.1
 python-stdnum==1.12
 Unidecode==1.1.1
-WooCommerce==2.1.1
 pycryptodome==3.9.8