From bbb6d7c004f2badd9c80381577d7faa9484f75c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Lo=C3=AFc=20Oberle?= Date: Thu, 7 May 2026 12:55:06 +0200 Subject: [PATCH] refactor(buying): replace raw sql with orm in supplier scorecard (#54771) Use frappe.get_all instead of frappe.db.sql to fetch standings list. --- .../supplier_scorecard_standing.py | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/erpnext/buying/doctype/supplier_scorecard_standing/supplier_scorecard_standing.py b/erpnext/buying/doctype/supplier_scorecard_standing/supplier_scorecard_standing.py index 7f1be82c343..5526b7fa365 100644 --- a/erpnext/buying/doctype/supplier_scorecard_standing/supplier_scorecard_standing.py +++ b/erpnext/buying/doctype/supplier_scorecard_standing/supplier_scorecard_standing.py @@ -40,14 +40,7 @@ def get_scoring_standing(standing_name: str): @frappe.whitelist() def get_standings_list(): - standings = frappe.db.sql( - """ - SELECT - scs.name - FROM - `tabSupplier Scorecard Standing` scs""", - {}, - as_dict=1, - ) + """Returns a list of all Supplier Scorecard Standings.""" + standings = frappe.get_all("Supplier Scorecard Standing", fields=["name"]) return standings