From ba9bbed038611bd6cf4c4ffe3192f5b78d78425e Mon Sep 17 00:00:00 2001 From: Raffael Meyer <14891507+barredterra@users.noreply.github.com> Date: Tue, 16 Dec 2025 13:24:50 +0100 Subject: [PATCH] fix(Rename Tool): use "Link" field instead of "Select" --- erpnext/utilities/doctype/rename_tool/rename_tool.js | 8 -------- erpnext/utilities/doctype/rename_tool/rename_tool.json | 8 +++++--- erpnext/utilities/doctype/rename_tool/rename_tool.py | 4 +++- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/erpnext/utilities/doctype/rename_tool/rename_tool.js b/erpnext/utilities/doctype/rename_tool/rename_tool.js index 47677a62500..621f8484f53 100644 --- a/erpnext/utilities/doctype/rename_tool/rename_tool.js +++ b/erpnext/utilities/doctype/rename_tool/rename_tool.js @@ -2,14 +2,6 @@ // License: GNU General Public License v3. See license.txt frappe.ui.form.on("Rename Tool", { - onload: function (frm) { - return frappe.call({ - method: "erpnext.utilities.doctype.rename_tool.rename_tool.get_doctypes", - callback: function (r) { - frm.set_df_property("select_doctype", "options", r.message); - }, - }); - }, refresh: function (frm) { frm.disable_save(); diff --git a/erpnext/utilities/doctype/rename_tool/rename_tool.json b/erpnext/utilities/doctype/rename_tool/rename_tool.json index ce843a360f9..036f60facc0 100644 --- a/erpnext/utilities/doctype/rename_tool/rename_tool.json +++ b/erpnext/utilities/doctype/rename_tool/rename_tool.json @@ -12,8 +12,10 @@ { "description": "Type of document to rename.", "fieldname": "select_doctype", - "fieldtype": "Select", - "label": "Select DocType" + "fieldtype": "Link", + "label": "Select DocType", + "link_filters": "[[\"DocType\",\"allow_rename\",\"=\",1],[\"DocType\",\"module\",\"!=\",\"Core\"]]", + "options": "DocType" }, { "description": "Attach a comma separated .csv file with two columns, one for the old name and one for the new name.", @@ -33,7 +35,7 @@ "issingle": 1, "links": [], "max_attachments": 1, - "modified": "2025-10-07 10:24:36.632780", + "modified": "2025-12-09 14:18:33.838623", "modified_by": "Administrator", "module": "Utilities", "name": "Rename Tool", diff --git a/erpnext/utilities/doctype/rename_tool/rename_tool.py b/erpnext/utilities/doctype/rename_tool/rename_tool.py index 38ee0f3bf81..0134d9c3e1e 100644 --- a/erpnext/utilities/doctype/rename_tool/rename_tool.py +++ b/erpnext/utilities/doctype/rename_tool/rename_tool.py @@ -7,6 +7,7 @@ import frappe from frappe.model.document import Document from frappe.model.rename_doc import bulk_rename +from frappe.utils.deprecations import deprecated class RenameTool(Document): @@ -19,13 +20,14 @@ class RenameTool(Document): from frappe.types import DF file_to_rename: DF.Attach | None - select_doctype: DF.Literal[None] + select_doctype: DF.Link | None # end: auto-generated types pass @frappe.whitelist() +@deprecated def get_doctypes(): return frappe.db.sql_list( """select name from tabDocType