nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-02-21 02:16:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: calculate discount percentage if discount amount is specified (#47806)

Browse Source 
(cherry picked from commit bb474f4f42)
This commit is contained in:
Mihir Kandoi
2025-05-31 20:52:14 +05:30
committed by Mergify
parent 3879cbd86d
commit ba8a316b06
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
erpnext/controllers/taxes_and_totals.py
View File

@@ -13,6 +13,7 @@ from frappe.utils.deprecations import deprecated
import erpnext import erpnext
from erpnext.accounts.doctype.journal_entry.journal_entry import get_exchange_rate from erpnext.accounts.doctype.journal_entry.journal_entry import get_exchange_rate
from erpnext.accounts.doctype.pricing_rule.utils import get_applied_pricing_rules from erpnext.accounts.doctype.pricing_rule.utils import get_applied_pricing_rules
from erpnext.accounts.utils import get_currency_precision
from erpnext.controllers.accounts_controller import ( from erpnext.controllers.accounts_controller import (
validate_conversion_rate, validate_conversion_rate,
validate_inclusive_tax, validate_inclusive_tax,
@@ -674,7 +675,16 @@ class calculate_taxes_and_totals:
tax.item_wise_tax_detail = json.dumps(tax.item_wise_tax_detail, separators=(",", ":")) tax.item_wise_tax_detail = json.dumps(tax.item_wise_tax_detail, separators=(",", ":"))
def set_discount_amount(self): def set_discount_amount(self):
if self.doc.additional_discount_percentage: if self.doc.discount_amount:
self.doc.additional_discount_percentage = flt(
flt(
self.doc.discount_amount / flt(self.doc.get(scrub(self.doc.apply_discount_on))),
get_currency_precision(),
)
* 100,
self.doc.precision("additional_discount_percentage"),
)
elif self.doc.additional_discount_percentage:
self.doc.discount_amount = flt( self.doc.discount_amount = flt(
flt(self.doc.get(scrub(self.doc.apply_discount_on))) flt(self.doc.get(scrub(self.doc.apply_discount_on)))
* self.doc.additional_discount_percentage * self.doc.additional_discount_percentage