From ba2faecdc7ad080695b369276d9827e418fe264d Mon Sep 17 00:00:00 2001 From: Shivam Mishra Date: Fri, 4 Oct 2019 11:58:04 +0530 Subject: [PATCH] fix: null check for valuation rate (#19195) * fix: null check for valuatiomn rate * fix: add rate for item in test records * refactor: use flt instead of throwing error * Revert "fix: add rate for item in test records" This reverts commit f8cebe65f5fe32382aba842f765d263511cbb082. --- erpnext/manufacturing/doctype/bom/bom.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/manufacturing/doctype/bom/bom.py b/erpnext/manufacturing/doctype/bom/bom.py index f82afb766c6..eb01b8c81e0 100644 --- a/erpnext/manufacturing/doctype/bom/bom.py +++ b/erpnext/manufacturing/doctype/bom/bom.py @@ -173,7 +173,7 @@ class BOM(WebsiteGenerator): #Customer Provided parts will have zero rate if not frappe.db.get_value('Item', arg["item_code"], 'is_customer_provided_item'): if arg.get('bom_no') and self.set_rate_of_sub_assembly_item_based_on_bom: - rate = self.get_bom_unitcost(arg['bom_no']) * (arg.get("conversion_factor") or 1) + rate = flt(self.get_bom_unitcost(arg['bom_no'])) * (arg.get("conversion_factor") or 1) else: if self.rm_cost_as_per == 'Valuation Rate': rate = self.get_valuation_rate(arg) * (arg.get("conversion_factor") or 1)