nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-25 07:54:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove remarks if show_remarks is unchecked (#49567)

Browse Source 
* fix: remove remarks if show_remarks is unchecked

* chore: resolve conflicts in accounts receivable

---------

Co-authored-by: mithili <mithili15602@gamil.com>
This commit is contained in:
Mithili G
2025-09-23 16:43:41 +05:30
committed by GitHub
parent 1979879b07
commit b98977dc75
2 changed files with 33 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts.html
View File

@@ -34,11 +34,13 @@
<thead> <thead>
<tr> <tr>
<th style="width: 12%">{{ _("Date") }}</th> <th style="width: 12%">{{ _("Date") }}</th>
<th style="width: 15%">{{ _("Reference") }}</th> <th style="width: 20%">{{ _("Reference") }}</th>
<th style="width: 25%">{{ _("Remarks") }}</th>
<th style="width: 15%">{{ _("Debit") }}</th> <th style="width: 15%">{{ _("Debit") }}</th>
<th style="width: 15%">{{ _("Credit") }}</th> <th style="width: 15%">{{ _("Credit") }}</th>
<th style="width: 18%">{{ _("Balance (Dr - Cr)") }}</th> <th style="width: 18%">{{ _("Balance (Dr - Cr)") }}</th>
{% if filters.show_remarks %}
<th style="width: 20%">{{ _("Remarks") }}</th>
{% endif %}
</tr> </tr>
</thead> </thead>
<tbody> <tbody>
@@ -47,36 +49,51 @@
{% if(row.posting_date) %} {% if(row.posting_date) %}
<td>{{ frappe.format(row.posting_date, 'Date') }}</td> <td>{{ frappe.format(row.posting_date, 'Date') }}</td>
<td>{{ row.voucher_type }} <td>{{ row.voucher_type }}
<br>{{ row.voucher_no }}</td> <br>{{ row.voucher_no }}
<td> {% if not (filters.party or filters.account) %}
{% if not (filters.party or filters.account) %}
{{ row.party or row.account }} {{ row.party or row.account }}
<br> <br>
{% endif %} {% endif %}
<br>{{ _("Remarks:") }} {{ row.remarks }}
{% if row.bill_no %} {% if row.bill_no %}
<br>{{ _("Supplier Invoice No") }}: {{ row.bill_no }} {{ _("Supplier Invoice No") }}: {{ row.bill_no }}
{% endif %} {% endif %}
</td> </td>
<td style="text-align: right"> <td style="text-align: right">
{{ frappe.utils.fmt_money(row.debit, currency=filters.presentation_currency) }}</td> {{ frappe.utils.fmt_money(row.debit, currency=filters.presentation_currency) }}</td>
<td style="text-align: right"> <td style="text-align: right">
{{ frappe.utils.fmt_money(row.credit, currency=filters.presentation_currency) }}</td> {{ frappe.utils.fmt_money(row.credit, currency=filters.presentation_currency) }}</td>
<td style="text-align: right">
{{ frappe.utils.fmt_money(row.balance, currency=filters.presentation_currency) }}
</td>
{% if filters.show_remarks %}
<td>
{% if row.remarks %}
{{ _("Remarks:") }} {{ row.remarks }}
{% endif %}
</td>
{% endif %}
{% else %} {% else %}
<td></td> <td></td>
<td></td> <td>
<td><b>{{ frappe.format(row.account, {fieldtype: "Link"}) or "&nbsp;" }}</b></td> <b>{{ frappe.format(row.account, {fieldtype: "Link"}) or "&nbsp;" }}</b>
</td>
<td style="text-align: right"> <td style="text-align: right">
{{ row.get('account', '') and frappe.utils.fmt_money(row.debit, currency=filters.presentation_currency) }} {{ row.get('account', '') and frappe.utils.fmt_money(row.debit, currency=filters.presentation_currency) }}
</td> </td>
<td style="text-align: right"> <td style="text-align: right">
{{ row.get('account', '') and frappe.utils.fmt_money(row.credit, currency=filters.presentation_currency) }} {{ row.get('account', '') and frappe.utils.fmt_money(row.credit, currency=filters.presentation_currency) }}
</td> </td>
{% endif %}
<td style="text-align: right"> <td style="text-align: right">
{{ frappe.utils.fmt_money(row.balance, currency=filters.presentation_currency) }} {{ frappe.utils.fmt_money(row.balance, currency=filters.presentation_currency) }}
</td> </td>
{% if filters.show_remarks %}
<td>
{% if row.remarks %}
{{ _("Remarks:") }} {{ row.remarks }}
{% endif %}
</td>
{% endif %}
{% endif %}
</tr> </tr>
{% endfor %} {% endfor %}
</tbody> </tbody>

8
erpnext/accounts/doctype/process_statement_of_accounts/process_statement_of_accounts_accounts_receivable.html
View File

@@ -159,7 +159,7 @@
{% else %} {% else %}
<th style="width: 24%">{{ _("Reference") }}</th> <th style="width: 24%">{{ _("Reference") }}</th>
{% endif %} {% endif %}
{% if not(filters.show_future_payments) %} {% if not(filters.show_future_payments) and filters.show_remarks %}
<th style="width: 20%"> <th style="width: 20%">
{% if (filters.customer or filters.supplier or filters.customer_name) %} {% if (filters.customer or filters.supplier or filters.customer_name) %}
{{ _("Remarks") }} {{ _("Remarks") }}
@@ -228,7 +228,7 @@
<td>{{ data[i]["sales_person"] }}</td> <td>{{ data[i]["sales_person"] }}</td>
{% endif %} {% endif %}
{% if not (filters.show_future_payments) %} {% if not (filters.show_future_payments) and filters.show_remarks %}
<td> <td>
{% if(not(filters.customer or filters.supplier or filters.customer_name)) %} {% if(not(filters.customer or filters.supplier or filters.customer_name)) %}
{{ data[i]["party"] }} {{ data[i]["party"] }}
@@ -327,7 +327,9 @@
{% endfor %} {% endfor %}
<td></td> <td></td>
<td></td> <td></td>
<td></td> {% if (filters.show_future_payments) or filters.show_remarks %}
<td></td>
{% endif %}
{% if not(filters.show_future_payments) %} {% if not(filters.show_future_payments) %}
<td></td> <td></td>
<td style="text-align: right"><b>{{ frappe.utils.fmt_money(data|sum(attribute="invoiced"), currency=data[0]["currency"]) }}</b></td> <td style="text-align: right"><b>{{ frappe.utils.fmt_money(data|sum(attribute="invoiced"), currency=data[0]["currency"]) }}</b></td>