From b919a7abff69cc82bdeb4ffe829f2673b3cda6a6 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Wed, 24 Jun 2026 12:37:46 +0530 Subject: [PATCH] ci: wait_for_redis fail-fast (greptile) --- .github/helper/install.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/helper/install.sh b/.github/helper/install.sh index 83a6cd5c8ed..263c12555bb 100644 --- a/.github/helper/install.sh +++ b/.github/helper/install.sh @@ -333,13 +333,17 @@ for key in ("redis_cache", "redis_queue"): PY ) for port in $ports; do + local up=0 for _ in $(seq 1 120); do if (exec 3<>"/dev/tcp/127.0.0.1/$port") 2>/dev/null; then - exec 3>&- 3<&- + exec 3>&- 3<&-; up=1 break fi sleep 1 done + # Fail clearly instead of letting reinstall die later on a vague socket-connection error + # when redis never bound. + [ "$up" = "1" ] || { echo "redis did not come up on port $port"; return 1; } done } wait_for_redis