nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-08 15:42:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(territory_wise_sales): replace SQL with query builder (#55176)

Browse Source
This commit is contained in:
Loic Oberle
2026-05-22 12:34:18 +02:00
committed by GitHub
parent 719cf8a48f
commit b84ec2d22a
1 changed files with 6 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/selling/report/territory_wise_sales/territory_wise_sales.py
View File

@@ -133,17 +133,13 @@ def get_quotations(opportunities):
if not opportunities: if not opportunities:
return [] return []
opportunity_names = [o.name for o in opportunities] opportunity_names = [o.get("name") for o in opportunities]
return frappe.db.sql( return frappe.get_all(
""" "Quotation",
SELECT `name`,`base_grand_total`, `opportunity` fields=["name", "base_grand_total", "opportunity"],
FROM `tabQuotation` filters={"docstatus": 1, "opportunity": ["in", opportunity_names]},
WHERE docstatus=1 AND opportunity in ({}) )
""".format(", ".join(["%s"] * len(opportunity_names))),
tuple(opportunity_names),
as_dict=1,
) # nosec
def get_sales_orders(quotations): def get_sales_orders(quotations):