mirror of
https://github.com/frappe/erpnext.git
synced 2026-08-14 07:01:56 +00:00
fix(manufacturing): correct nested BOM quantities
This commit is contained in:
@@ -24,7 +24,7 @@ def get_exploded_items(bom, data, indent=0, qty=1):
|
|||||||
fields=[
|
fields=[
|
||||||
"qty",
|
"qty",
|
||||||
"bom_no",
|
"bom_no",
|
||||||
"qty",
|
"stock_qty",
|
||||||
"item_code",
|
"item_code",
|
||||||
"item_name",
|
"item_name",
|
||||||
"description",
|
"description",
|
||||||
@@ -51,7 +51,13 @@ def get_exploded_items(bom, data, indent=0, qty=1):
|
|||||||
}
|
}
|
||||||
)
|
)
|
||||||
if item.bom_no:
|
if item.bom_no:
|
||||||
get_exploded_items(item.bom_no, data, indent=indent + 1, qty=item.qty)
|
child_bom_qty = frappe.get_cached_value("BOM", item.bom_no, "quantity")
|
||||||
|
get_exploded_items(
|
||||||
|
item.bom_no,
|
||||||
|
data,
|
||||||
|
indent=indent + 1,
|
||||||
|
qty=qty * item.stock_qty / child_bom_qty,
|
||||||
|
)
|
||||||
|
|
||||||
|
|
||||||
def get_columns():
|
def get_columns():
|
||||||
|
|||||||
@@ -0,0 +1,47 @@
|
|||||||
|
# Copyright (c) 2026, Frappe Technologies Pvt. Ltd. and Contributors
|
||||||
|
# See license.txt
|
||||||
|
|
||||||
|
import unittest
|
||||||
|
from unittest.mock import patch
|
||||||
|
|
||||||
|
import frappe
|
||||||
|
|
||||||
|
from erpnext.manufacturing.report.bom_explorer.bom_explorer import get_exploded_items
|
||||||
|
|
||||||
|
|
||||||
|
class TestBOMExplorer(unittest.TestCase):
|
||||||
|
def test_nested_bom_normalizes_and_accumulates_qty(self):
|
||||||
|
def item(item_code, qty, stock_qty, bom_no="", uom="Nos"):
|
||||||
|
return frappe._dict(
|
||||||
|
item_code=item_code,
|
||||||
|
item_name=item_code,
|
||||||
|
description="",
|
||||||
|
qty=qty,
|
||||||
|
stock_qty=stock_qty,
|
||||||
|
bom_no=bom_no,
|
||||||
|
uom=uom,
|
||||||
|
idx=1,
|
||||||
|
is_phantom_item=0,
|
||||||
|
)
|
||||||
|
|
||||||
|
children = {
|
||||||
|
"root": [item("parent", 2, 20, "parent-bom", "Box")],
|
||||||
|
"parent-bom": [item("child", 3, 12, "child-bom", "Pack")],
|
||||||
|
"child-bom": [item("raw-material", 2, 2, uom="Kg")],
|
||||||
|
}
|
||||||
|
bom_quantities = {"parent-bom": 5, "child-bom": 4}
|
||||||
|
|
||||||
|
def get_items(_doctype, filters, **kwargs):
|
||||||
|
return children[filters["parent"]]
|
||||||
|
|
||||||
|
def get_bom_quantity(_doctype, name, _fieldname):
|
||||||
|
return bom_quantities[name]
|
||||||
|
|
||||||
|
data = []
|
||||||
|
with (
|
||||||
|
patch.object(frappe, "get_all", side_effect=get_items),
|
||||||
|
patch.object(frappe, "get_cached_value", side_effect=get_bom_quantity),
|
||||||
|
):
|
||||||
|
get_exploded_items("root", data)
|
||||||
|
|
||||||
|
self.assertEqual([row["qty"] for row in data], [2, 12, 24])
|
||||||
Reference in New Issue
Block a user