nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-16 02:11:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: avoid per-row Warehouse doc fetches in auto reorder job

Browse Source 
get_item_warehouse_projected_qty ran an uncached frappe.get_doc per Bin
row to walk the warehouse parent chain, re-fetching the same ancestors
for every item sharing a warehouse. Preload the warehouse parent map
once and walk it in memory instead.

(cherry picked from commit 6beb3d2509)

# Conflicts:
#	erpnext/stock/reorder_item.py
This commit is contained in:
pandiyan
2026-07-07 11:43:52 +05:30
committed by Mergify
parent 55e0d106c9
commit b3c8693854
1 changed files with 18 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
erpnext/stock/reorder_item.py
View File

@@ -186,6 +186,7 @@ def get_item_warehouse_projected_qty(items_to_consider):
item_warehouse_projected_qty = {} item_warehouse_projected_qty = {}
items_to_consider = list(items_to_consider.keys()) items_to_consider = list(items_to_consider.keys())
<<<<<<< HEAD
for item_code, warehouse, projected_qty in frappe.db.sql( for item_code, warehouse, projected_qty in frappe.db.sql(
"""select item_code, warehouse, projected_qty """select item_code, warehouse, projected_qty
from tabBin where item_code in ({}) from tabBin where item_code in ({})
@@ -193,6 +194,17 @@ def get_item_warehouse_projected_qty(items_to_consider):
", ".join(["%s"] * len(items_to_consider)) ", ".join(["%s"] * len(items_to_consider))
), ),
items_to_consider, items_to_consider,
=======
warehouse_parent_map = frappe._dict(
frappe.get_all("Warehouse", fields=["name", "parent_warehouse"], as_list=True)
)
for item_code, warehouse, projected_qty in frappe.get_all(
"Bin",
filters={"item_code": ["in", items_to_consider], "warehouse": ["is", "set"]},
fields=["item_code", "warehouse", "projected_qty"],
as_list=True,
>>>>>>> 6beb3d2509 (perf: avoid per-row Warehouse doc fetches in auto reorder job)
): ):
if item_code not in item_warehouse_projected_qty: if item_code not in item_warehouse_projected_qty:
item_warehouse_projected_qty.setdefault(item_code, {}) item_warehouse_projected_qty.setdefault(item_code, {})
@@ -200,16 +212,14 @@ def get_item_warehouse_projected_qty(items_to_consider):
if warehouse not in item_warehouse_projected_qty.get(item_code): if warehouse not in item_warehouse_projected_qty.get(item_code):
item_warehouse_projected_qty[item_code][warehouse] = flt(projected_qty) item_warehouse_projected_qty[item_code][warehouse] = flt(projected_qty)
warehouse_doc = frappe.get_doc("Warehouse", warehouse) parent_warehouse = warehouse_parent_map.get(warehouse)
while warehouse_doc.parent_warehouse: while parent_warehouse:
if not item_warehouse_projected_qty.get(item_code, {}).get(warehouse_doc.parent_warehouse): if not item_warehouse_projected_qty.get(item_code, {}).get(parent_warehouse):
item_warehouse_projected_qty.setdefault(item_code, {})[warehouse_doc.parent_warehouse] = flt( item_warehouse_projected_qty.setdefault(item_code, {})[parent_warehouse] = flt(projected_qty)
projected_qty
)
else: else:
item_warehouse_projected_qty[item_code][warehouse_doc.parent_warehouse] += flt(projected_qty) item_warehouse_projected_qty[item_code][parent_warehouse] += flt(projected_qty)
warehouse_doc = frappe.get_doc("Warehouse", warehouse_doc.parent_warehouse) parent_warehouse = warehouse_parent_map.get(parent_warehouse)
return item_warehouse_projected_qty return item_warehouse_projected_qty