From b23570c1b3bc6f0f719511ed47a41567d9dd6f96 Mon Sep 17 00:00:00 2001 From: ruthra kumar Date: Fri, 30 Jan 2026 11:15:23 +0530 Subject: [PATCH] refactor(test): remove redundant create_asset_category --- .../doctype/purchase_invoice/test_purchase_invoice.py | 5 ----- erpnext/stock/doctype/item/test_item.py | 4 ++-- .../doctype/landed_cost_voucher/test_landed_cost_voucher.py | 5 +---- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py b/erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py index 5c11172c4b5..1c51daccd60 100644 --- a/erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py +++ b/erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py @@ -2454,11 +2454,6 @@ class TestPurchaseInvoice(ERPNextTestSuite, StockTestMixin): self.assertEqual(row.rejected_serial_no, serial_nos[2]) def test_make_pr_and_pi_from_po(self): - from erpnext.assets.doctype.asset.test_asset import create_asset_category - - if not frappe.db.exists("Asset Category", "Computers"): - create_asset_category() - item = create_item( item_code="_Test_Item", is_stock_item=0, is_fixed_asset=1, asset_category="Computers" ) diff --git a/erpnext/stock/doctype/item/test_item.py b/erpnext/stock/doctype/item/test_item.py index 6ca1ebc46f9..d2b0f59ae97 100644 --- a/erpnext/stock/doctype/item/test_item.py +++ b/erpnext/stock/doctype/item/test_item.py @@ -169,9 +169,9 @@ class TestItem(ERPNextTestSuite): self.assertEqual(value, details.get(key), key) def test_get_asset_item_details(self): - from erpnext.assets.doctype.asset.test_asset import create_asset_category, create_fixed_asset_item + from erpnext.assets.doctype.asset.test_asset import create_fixed_asset_item - create_asset_category(0) + frappe.db.set_value("Asset Category", "Computers", "enable_cwip_accounting", 0) create_fixed_asset_item() details = get_item_details( diff --git a/erpnext/stock/doctype/landed_cost_voucher/test_landed_cost_voucher.py b/erpnext/stock/doctype/landed_cost_voucher/test_landed_cost_voucher.py index 5a9cf4b76ca..0645957a22a 100644 --- a/erpnext/stock/doctype/landed_cost_voucher/test_landed_cost_voucher.py +++ b/erpnext/stock/doctype/landed_cost_voucher/test_landed_cost_voucher.py @@ -10,7 +10,7 @@ from frappe.utils import add_days, add_to_date, flt, now, nowtime, today from erpnext.accounts.doctype.account.test_account import create_account, get_inventory_account from erpnext.accounts.doctype.purchase_invoice.test_purchase_invoice import make_purchase_invoice from erpnext.accounts.utils import update_gl_entries_after -from erpnext.assets.doctype.asset.test_asset import create_asset_category, create_fixed_asset_item +from erpnext.assets.doctype.asset.test_asset import create_fixed_asset_item from erpnext.stock.doctype.delivery_note.test_delivery_note import create_delivery_note from erpnext.stock.doctype.purchase_receipt.test_purchase_receipt import ( get_gl_entries, @@ -604,9 +604,6 @@ class TestLandedCostVoucher(ERPNextTestSuite): "Company", "_Test Company", "capital_work_in_progress_account", "CWIP Account - _TC" ) - if not frappe.db.exists("Asset Category", "Computers"): - create_asset_category() - if not frappe.db.exists("Item", "Macbook Pro"): create_fixed_asset_item()