nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-24 15:39:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: decimal garbage on variable total (#46621)

Browse Source 
* fix: decimal dirty on variable total

* fix: linters

* fix: decimal garbage, code improvement
This commit is contained in:
HarryPaulo
2025-03-21 10:14:16 -03:00
committed by GitHub
parent d3f8263890
commit b0dccadd26
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/accounts/doctype/journal_entry/journal_entry.py
View File

@@ -828,14 +828,13 @@ class JournalEntry(AccountsController):
"Debit Note", "Debit Note",
"Credit Note", "Credit Note",
]: ]:
invoice = frappe.db.get_value( invoice = frappe.get_doc(reference_type, reference_name)
reference_type, reference_name, ["docstatus", "outstanding_amount"], as_dict=1
)
if invoice.docstatus != 1: if invoice.docstatus != 1:
frappe.throw(_("{0} {1} is not submitted").format(reference_type, reference_name)) frappe.throw(_("{0} {1} is not submitted").format(reference_type, reference_name))
if total and flt(invoice.outstanding_amount) < total: precision = invoice.precision("outstanding_amount")
if total and flt(invoice.outstanding_amount, precision) < flt(total, precision):
frappe.throw( frappe.throw(
_("Payment against {0} {1} cannot be greater than Outstanding Amount {2}").format( _("Payment against {0} {1} cannot be greater than Outstanding Amount {2}").format(
reference_type, reference_name, invoice.outstanding_amount reference_type, reference_name, invoice.outstanding_amount