nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-03 16:40:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(accounts): log bank-entry failure without the rolled-back doc (review)

Browse Source 
The savepoint rollback erases the just-inserted Bank Transaction row, so bank_transaction.log_error() created an Error Log pointing at a row that no longer exists. Use frappe.log_error(title=...) with no doc reference.
This commit is contained in:
Mihir Kandoi
2026-06-30 12:17:36 +05:30
parent f41e8208d8
commit b0331f13f1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/accounts/doctype/bank_transaction/bank_transaction_upload.py
View File

@@ -58,7 +58,7 @@ def create_bank_entries(columns: str, data: str | list, bank_account: str):
success += 1 success += 1
except Exception: except Exception:
frappe.db.rollback(save_point="bank_entry") frappe.db.rollback(save_point="bank_entry")
bank_transaction.log_error("Bank entry creation failed") frappe.log_error(title="Bank entry creation failed")
errors += 1 errors += 1
return {"success": success, "errors": errors} return {"success": success, "errors": errors}