nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-16 02:11:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: guard scio row lookup in stock entry items_add

Browse Source 
check the result of find() before reading t_warehouse off it. on a
'receive from customer' entry with no row carrying scio_detail, find()
returns undefined and items_add throws a typeerror.

the throw rejects the serially-run handler chain, so the stock entry
controller's own items_add never runs and the new row silently loses
its target warehouse, expense account, cost center and serial/batch
field defaults.

leave t_warehouse unset when no reference row exists, so the rest of
the chain still runs.

(cherry picked from commit 6e444a1832)

# Conflicts:
#	erpnext/stock/doctype/stock_entry/stock_entry.js
This commit is contained in:
pandiyan
2026-07-29 23:12:45 +05:30
committed by Mergify
parent f2ec60b7a5
commit adbc67ef11
1 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/stock/doctype/stock_entry/stock_entry.js
View File

@@ -964,6 +964,16 @@ frappe.ui.form.on("Stock Entry Detail", {
if (item.is_finished_item) { if (item.is_finished_item) {
frm.events.set_fg_completed_qty(frm); frm.events.set_fg_completed_qty(frm);
} }
<<<<<<< HEAD
=======
if (frm.doc.purpose === "Receive from Customer") {
const scio_row = frm.doc.items.find((row) => row.scio_detail);
if (scio_row) {
item.t_warehouse = scio_row.t_warehouse;
}
}
>>>>>>> 6e444a1832 (fix: guard scio row lookup in stock entry items_add)
}, },
set_basic_rate_manually(frm, cdt, cdn) { set_basic_rate_manually(frm, cdt, cdn) {
let row = locals[cdt][cdn]; let row = locals[cdt][cdn];