fix: make ledger entries submittable and cleanup invalid test submissions (#52921)

* fix: enable submittability for ledger entries and cleanup invalid test submissions

* fix: reverted child table submittability

* fix: added ignore_links flag for back gl entry

* fix: add ignore_links for reconcile,cancelled PLE,cancelled SLE

* fix: update test_recreate_stock_ledgers to use db.delete instead of doc.delete

* chore: temporary test against frappe PR 37009

* fix: make Advance Payment Ledger Entry submittable

* refactor: add extra line for create_shipping_rule

* chore: revert temporary test against frappe PR 37009

* fix: use parent doc save with ignore_validate_update_after_submit for child table updates

* chore: temporary test against frappe PR 37009

* chore: revert temporary test against frappe PR 37009

* fix: use skip_docstatus_validation

erpnext/controllers/subcontracting_inward_controller.py

@@ -721,6 +721,7 @@ class SubcontractingInwardController:
 						"Subcontracting Inward Order Item", item.against_fg, "item_code"
 					),
 				)
+				scio_rm.skip_docstatus_validation = True
 				scio_rm.insert()
 				scio_rm.submit()
 				item.db_set("scio_detail", scio_rm.name)
@@ -867,6 +868,7 @@ class SubcontractingInwardController:
 					warehouse=extra_item.s_warehouse,
 					is_additional_item=True,
 				)
+				doc.skip_docstatus_validation = True
 				doc.insert()
 				doc.submit()
 
@@ -954,6 +956,7 @@ class SubcontractingInwardController:
 							"Work Order", self.work_order, "subcontracting_inward_order_item"
 						),
 					)
+					doc.skip_docstatus_validation = True
 					doc.insert()
 					doc.submit()
 

erpnext/controllers/tests/test_accounts_controller.py

@@ -2483,7 +2483,7 @@ class TestAccountsController(IntegrationTestCase):
 	def test_document_naming_rule_based_on_posting_date(self):
 		frappe.new_doc(
 			"Document Naming Rule", document_type="Sales Invoice", prefix="SI-.MM.-.YYYY.-"
-		).submit()
+		).insert()
 
 		si = create_sales_invoice(do_not_save=True)
 		si.set_posting_time = 1