nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-04-23 08:38:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: slow posting datetime update (backport #44799) (#44805)

Browse Source 
fix: slow posting datetime update (#44799)

(cherry picked from commit a7b5e2565b)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
This commit is contained in:
mergify[bot]
2024-12-20 19:38:52 +05:30
committed by GitHub
parent 58c0e24f2d
commit ad57e33cd7
4 changed files with 6 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/stock/doctype/serial_and_batch_bundle/test_serial_and_batch_bundle.py
View File

@@ -186,6 +186,7 @@ class TestSerialandBatchBundle(FrappeTestCase):
} }
) )
doc.set_posting_datetime()
doc.flags.ignore_permissions = True doc.flags.ignore_permissions = True
doc.flags.ignore_mandatory = True doc.flags.ignore_mandatory = True
doc.flags.ignore_links = True doc.flags.ignore_links = True
@@ -586,6 +587,7 @@ class TestSerialandBatchBundle(FrappeTestCase):
"company": "_Test Company", "company": "_Test Company",
} }
) )
doc.set_posting_datetime()
doc.flags.ignore_permissions = True doc.flags.ignore_permissions = True
doc.flags.ignore_mandatory = True doc.flags.ignore_mandatory = True
doc.flags.ignore_links = True doc.flags.ignore_links = True

11
erpnext/stock/doctype/stock_ledger_entry/stock_ledger_entry.py
View File

@@ -88,6 +88,7 @@ class StockLedgerEntry(Document):
self.flags.ignore_submit_comment = True self.flags.ignore_submit_comment = True
from erpnext.stock.utils import validate_disabled_warehouse, validate_warehouse_company from erpnext.stock.utils import validate_disabled_warehouse, validate_warehouse_company
self.set_posting_datetime()
self.validate_mandatory() self.validate_mandatory()
self.validate_batch() self.validate_batch()
validate_disabled_warehouse(self.warehouse) validate_disabled_warehouse(self.warehouse)
@@ -98,15 +99,10 @@ class StockLedgerEntry(Document):
self.validate_with_last_transaction_posting_time() self.validate_with_last_transaction_posting_time()
self.validate_inventory_dimension_negative_stock() self.validate_inventory_dimension_negative_stock()
def set_posting_datetime(self, save=False): def set_posting_datetime(self):
from erpnext.stock.utils import get_combine_datetime from erpnext.stock.utils import get_combine_datetime
if save: self.posting_datetime = get_combine_datetime(self.posting_date, self.posting_time)
posting_datetime = get_combine_datetime(self.posting_date, self.posting_time)
if not self.posting_datetime or self.posting_datetime != posting_datetime:
self.db_set("posting_datetime", posting_datetime)
else:
self.posting_datetime = get_combine_datetime(self.posting_date, self.posting_time)
def validate_inventory_dimension_negative_stock(self): def validate_inventory_dimension_negative_stock(self):
if self.is_cancelled or self.actual_qty >= 0: if self.is_cancelled or self.actual_qty >= 0:
@@ -173,7 +169,6 @@ class StockLedgerEntry(Document):
return inv_dimension_dict return inv_dimension_dict
def on_submit(self): def on_submit(self):
self.set_posting_datetime(save=True)
self.check_stock_frozen_date() self.check_stock_frozen_date()
# Added to handle few test cases where serial_and_batch_bundles are not required # Added to handle few test cases where serial_and_batch_bundles are not required

1
erpnext/stock/doctype/stock_reconciliation/test_stock_reconciliation.py
View File

@@ -1242,6 +1242,7 @@ class TestStockReconciliation(FrappeTestCase, StockTestMixin):
} }
) )
doc.set_posting_datetime()
doc.flags.ignore_permissions = True doc.flags.ignore_permissions = True
doc.flags.ignore_mandatory = True doc.flags.ignore_mandatory = True
doc.flags.ignore_links = True doc.flags.ignore_links = True

1
erpnext/stock/stock_ledger.py
View File

@@ -222,7 +222,6 @@ def make_entry(args, allow_negative_stock=False, via_landed_cost_voucher=False):
sle.flags.ignore_permissions = 1 sle.flags.ignore_permissions = 1
sle.allow_negative_stock = allow_negative_stock sle.allow_negative_stock = allow_negative_stock
sle.via_landed_cost_voucher = via_landed_cost_voucher sle.via_landed_cost_voucher = via_landed_cost_voucher
sle.set_posting_datetime()
sle.submit() sle.submit()
# Added to handle the case when the stock ledger entry is created from the repostig # Added to handle the case when the stock ledger entry is created from the repostig