nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-04 20:59:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: replace get_query with get_list for permission-aware queries in v15

Browse Source
This commit is contained in:
khushi8112
2026-06-02 12:17:37 +05:30
parent 264433b23d
commit ad511b80c0
1 changed files with 13 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
erpnext/selling/report/sales_analytics/sales_analytics.py
View File

@@ -139,16 +139,16 @@ class Analytics:
self.get_rows() self.get_rows()
def _get_permitted_parent_names(self): def _get_permitted_parent_names(self):
return frappe.qb.get_query( return frappe.get_list(
table=self.filters.doc_type, self.filters.doc_type,
fields=["name"], fields=["name"],
filters={ filters={
"docstatus": 1, "docstatus": 1,
"company": ["in", self.filters.company], "company": ["in", self.filters.company],
self.date_field: ("between", [self.filters.from_date, self.filters.to_date]), self.date_field: ("between", [self.filters.from_date, self.filters.to_date]),
}, },
ignore_permissions=False, pluck="name",
).run(pluck="name") )
def get_sales_transactions_based_on_order_type(self): def get_sales_transactions_based_on_order_type(self):
if self.filters["value_quantity"] == "Value": if self.filters["value_quantity"] == "Value":
@@ -199,12 +199,11 @@ class Analytics:
if self.filters.doc_type in ["Sales Invoice", "Purchase Invoice", "Payment Entry"]: if self.filters.doc_type in ["Sales Invoice", "Purchase Invoice", "Payment Entry"]:
filters.update({"is_opening": "No"}) filters.update({"is_opening": "No"})
self.entries = frappe.qb.get_query( self.entries = frappe.get_list(
table=self.filters.doc_type, self.filters.doc_type,
fields=[entity, entity_name, value_field, self.date_field], fields=[entity, entity_name, value_field, self.date_field],
filters=filters, filters=filters,
ignore_permissions=False, )
).run(as_dict=True)
self.entity_names = {} self.entity_names = {}
for d in self.entries: for d in self.entries:
@@ -266,12 +265,11 @@ class Analytics:
if self.filters.doc_type in ["Sales Invoice", "Purchase Invoice", "Payment Entry"]: if self.filters.doc_type in ["Sales Invoice", "Purchase Invoice", "Payment Entry"]:
filters.update({"is_opening": "No"}) filters.update({"is_opening": "No"})
self.entries = frappe.qb.get_query( self.entries = frappe.get_list(
table=self.filters.doc_type, self.filters.doc_type,
fields=[entity_field, value_field, self.date_field], fields=[entity_field, value_field, self.date_field],
filters=filters, filters=filters,
ignore_permissions=False, )
).run(as_dict=True)
self.get_groups() self.get_groups()
def get_sales_transactions_based_on_item_group(self): def get_sales_transactions_based_on_item_group(self):
@@ -321,12 +319,11 @@ class Analytics:
if self.filters.doc_type in ["Sales Invoice", "Purchase Invoice", "Payment Entry"]: if self.filters.doc_type in ["Sales Invoice", "Purchase Invoice", "Payment Entry"]:
filters.update({"is_opening": "No"}) filters.update({"is_opening": "No"})
self.entries = frappe.qb.get_query( self.entries = frappe.get_list(
table=self.filters.doc_type, self.filters.doc_type,
fields=[entity, value_field, self.date_field], fields=[entity, value_field, self.date_field],
filters=filters, filters=filters,
ignore_permissions=False, )
).run(as_dict=True)
def get_rows(self): def get_rows(self):
self.data = [] self.data = []