From ad22256b2d8c35462ac46fdbcbb698ee4a522ba1 Mon Sep 17 00:00:00 2001 From: ervishnucs Date: Sun, 5 Apr 2026 11:16:37 +0530 Subject: [PATCH] fix: resolve item tax template from item group in update items --- erpnext/controllers/accounts_controller.py | 7 ++----- erpnext/stock/get_item_details.py | 18 +++++++++++++----- 2 files changed, 15 insertions(+), 10 deletions(-) diff --git a/erpnext/controllers/accounts_controller.py b/erpnext/controllers/accounts_controller.py index b7de552330e..68a2c3b7b02 100644 --- a/erpnext/controllers/accounts_controller.py +++ b/erpnext/controllers/accounts_controller.py @@ -71,6 +71,7 @@ from erpnext.stock.doctype.packed_item.packed_item import make_packing_list from erpnext.stock.get_item_details import ( ItemDetailsCtx, _get_item_tax_template, + _get_item_tax_template_from_item_group, get_conversion_factor, get_item_details, get_item_tax_map, @@ -3671,11 +3672,7 @@ def set_child_tax_template_and_map(item, child_item, parent_doc): item_tax_template = _get_item_tax_template(ctx, item.taxes) if not item_tax_template: - item_group = item.item_group - while item_group and not item_tax_template: - item_group_doc = frappe.get_cached_doc("Item Group", item_group) - item_tax_template = _get_item_tax_template(ctx, item_group_doc.taxes) - item_group = item_group_doc.parent_item_group + item_tax_template = _get_item_tax_template_from_item_group(ctx, item.item_group) child_item.item_tax_template = item_tax_template child_item.item_tax_rate = get_item_tax_map( diff --git a/erpnext/stock/get_item_details.py b/erpnext/stock/get_item_details.py index b7d4b5c47b7..b28608fdb02 100644 --- a/erpnext/stock/get_item_details.py +++ b/erpnext/stock/get_item_details.py @@ -731,11 +731,7 @@ def get_item_tax_template(ctx: ItemDetailsCtx, item: Document | None = None, out item_tax_template = _get_item_tax_template(ctx, item.taxes, out) if not item_tax_template: - item_group = item.item_group - while item_group and not item_tax_template: - item_group_doc = frappe.get_cached_doc("Item Group", item_group) - item_tax_template = _get_item_tax_template(ctx, item_group_doc.taxes, out) - item_group = item_group_doc.parent_item_group + item_tax_template = _get_item_tax_template_from_item_group(ctx, item.item_group, out) if out and ctx.get("child_doctype") and item_tax_template: out.update(get_fetch_values(ctx.get("child_doctype"), "item_tax_template", item_tax_template)) @@ -743,6 +739,18 @@ def get_item_tax_template(ctx: ItemDetailsCtx, item: Document | None = None, out return item_tax_template +def _get_item_tax_template_from_item_group(ctx, item_group, out=None): + from frappe.utils.nestedset import get_ancestors_of + + ancestors = get_ancestors_of("Item Group", item_group) + for group in [item_group, *ancestors]: + group_doc = frappe.get_cached_doc("Item Group", group) + item_tax_template = _get_item_tax_template(ctx, group_doc.taxes, out) + if item_tax_template: + return item_tax_template + return None + + @erpnext.normalize_ctx_input(ItemDetailsCtx) def _get_item_tax_template( ctx: ItemDetailsCtx, taxes, out: ItemDetails | None = None, for_validate=False