diff --git a/erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.py b/erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.py index d791c354cf8..8ff32a47ec6 100644 --- a/erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.py +++ b/erpnext/buying/doctype/supplier_scorecard/supplier_scorecard.py @@ -207,25 +207,16 @@ def make_all_scorecards(docname: str): while (start_date < todays) and (end_date <= todays): # check to make sure there is no scorecard period already created - scorecards = frappe.db.sql( - """ - SELECT - scp.name - FROM - `tabSupplier Scorecard Period` scp - WHERE - scp.scorecard = %(sc)s - AND scp.docstatus = 1 - AND ( - (scp.start_date > %(end_date)s - AND scp.end_date < %(start_date)s) - OR - (scp.start_date < %(end_date)s - AND scp.end_date > %(start_date)s)) - ORDER BY - scp.end_date DESC""", - {"sc": docname, "start_date": start_date, "end_date": end_date}, - as_dict=1, + scorecards = frappe.get_all( + "Supplier Scorecard Period", + fields=["name"], + filters={ + "scorecard": docname, + "docstatus": 1, + "start_date": ["<", end_date], + "end_date": [">", start_date], + }, + order_by="end_date desc", ) if len(scorecards) == 0: period_card = make_supplier_scorecard(docname, None)