From 405d901514519a043e43dafa9b9b14f350536a44 Mon Sep 17 00:00:00 2001 From: Pugazhendhi Velu Date: Wed, 5 Nov 2025 17:34:55 +0000 Subject: [PATCH 1/2] fix: add validation to reject empty readings --- .../stock/doctype/quality_inspection/quality_inspection.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/erpnext/stock/doctype/quality_inspection/quality_inspection.py b/erpnext/stock/doctype/quality_inspection/quality_inspection.py index c7a315d2298..faef473a7fa 100644 --- a/erpnext/stock/doctype/quality_inspection/quality_inspection.py +++ b/erpnext/stock/doctype/quality_inspection/quality_inspection.py @@ -283,9 +283,11 @@ class QualityInspection(Document): def min_max_criteria_passed(self, reading): """Determine whether all readings fall in the acceptable range.""" + has_reading = False for i in range(1, 11): reading_value = reading.get("reading_" + str(i)) if reading_value is not None and reading_value.strip(): + has_reading = True result = ( flt(reading.get("min_value")) <= parse_float(reading_value) @@ -293,7 +295,7 @@ class QualityInspection(Document): ) if not result: return False - return True + return has_reading def set_status_based_on_acceptance_formula(self, reading): if not reading.acceptance_formula: From 63fb9f55e7935b247d419f6b2a1efda21831eb48 Mon Sep 17 00:00:00 2001 From: Pugazhendhi Velu Date: Thu, 6 Nov 2025 06:32:04 +0000 Subject: [PATCH 2/2] refactor: add default reading value when creating a quality inspection --- .../stock/doctype/quality_inspection/test_quality_inspection.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/stock/doctype/quality_inspection/test_quality_inspection.py b/erpnext/stock/doctype/quality_inspection/test_quality_inspection.py index 15167286b9b..8c4622a8ae2 100644 --- a/erpnext/stock/doctype/quality_inspection/test_quality_inspection.py +++ b/erpnext/stock/doctype/quality_inspection/test_quality_inspection.py @@ -292,7 +292,7 @@ def create_quality_inspection(**args): if not args.readings: create_quality_inspection_parameter("Size") - readings = {"specification": "Size", "min_value": 0, "max_value": 10} + readings = {"specification": "Size", "min_value": 0, "max_value": 10, "reading_1": "5"} if args.status == "Rejected": readings["reading_1"] = "12" # status is auto set in child on save else: