From aab7cd1ae61e4d44b39c74e2e9b2a70b75482c41 Mon Sep 17 00:00:00 2001 From: Mihir Kandoi Date: Thu, 27 Nov 2025 16:49:03 +0530 Subject: [PATCH] chore: make unnecessary field read only and show only when required --- .../purchase_receipt/purchase_receipt.js | 27 ------------------- .../purchase_receipt/purchase_receipt.json | 6 ++--- 2 files changed, 3 insertions(+), 30 deletions(-) diff --git a/erpnext/stock/doctype/purchase_receipt/purchase_receipt.js b/erpnext/stock/doctype/purchase_receipt/purchase_receipt.js index 29026969404..ce462f73039 100644 --- a/erpnext/stock/doctype/purchase_receipt/purchase_receipt.js +++ b/erpnext/stock/doctype/purchase_receipt/purchase_receipt.js @@ -35,15 +35,6 @@ frappe.ui.form.on("Purchase Receipt", { filters: { company: frm.doc.company }, }; }); - - frm.set_query("subcontracting_receipt", function () { - return { - filters: { - docstatus: 1, - supplier: frm.doc.supplier, - }, - }; - }); }, onload: function (frm) { erpnext.queries.setup_queries(frm, "Warehouse", function () { @@ -167,24 +158,6 @@ frappe.ui.form.on("Purchase Receipt", { erpnext.accounts.dimensions.update_dimension(frm, frm.doctype); }, - subcontracting_receipt: (frm) => { - if ( - frm.doc.is_subcontracted === 1 && - frm.doc.is_old_subcontracting_flow === 0 && - frm.doc.subcontracting_receipt - ) { - frm.set_value("items", null); - - erpnext.utils.map_current_doc({ - method: "erpnext.subcontracting.doctype.subcontracting_receipt.subcontracting_receipt.make_purchase_receipt", - source_name: frm.doc.subcontracting_receipt, - target_doc: frm, - freeze: true, - freeze_message: __("Mapping Purchase Receipt ..."), - }); - } - }, - toggle_display_account_head: function (frm) { var enabled = erpnext.is_perpetual_inventory_enabled(frm.doc.company); frm.fields_dict["items"].grid.set_column_disp(["cost_center"], enabled); diff --git a/erpnext/stock/doctype/purchase_receipt/purchase_receipt.json b/erpnext/stock/doctype/purchase_receipt/purchase_receipt.json index 1c8fccf4849..077bda82e81 100755 --- a/erpnext/stock/doctype/purchase_receipt/purchase_receipt.json +++ b/erpnext/stock/doctype/purchase_receipt/purchase_receipt.json @@ -1249,11 +1249,12 @@ "label": "Named Place" }, { - "depends_on": "eval: (doc.is_subcontracted && !doc.is_old_subcontracting_flow)", + "depends_on": "subcontracting_receipt", "fieldname": "subcontracting_receipt", "fieldtype": "Link", "label": "Subcontracting Receipt", "options": "Subcontracting Receipt", + "read_only": 1, "search_index": 1 }, { @@ -1309,7 +1310,7 @@ "idx": 261, "is_submittable": 1, "links": [], - "modified": "2025-11-12 19:53:48.173096", + "modified": "2025-11-27 16:46:30.210628", "modified_by": "Administrator", "module": "Stock", "name": "Purchase Receipt", @@ -1380,4 +1381,3 @@ "title_field": "title", "track_changes": 1 } -