From 03d6550db3c1ae10b273deed2110f4897a4ad5d1 Mon Sep 17 00:00:00 2001 From: ravibharathi656 Date: Fri, 18 Jul 2025 11:36:12 +0530 Subject: [PATCH 1/2] revert: do not set pay_to_recd_from to None --- erpnext/accounts/doctype/journal_entry/journal_entry.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/erpnext/accounts/doctype/journal_entry/journal_entry.py b/erpnext/accounts/doctype/journal_entry/journal_entry.py index 9d30c3b39e5..8767d1e0e38 100644 --- a/erpnext/accounts/doctype/journal_entry/journal_entry.py +++ b/erpnext/accounts/doctype/journal_entry/journal_entry.py @@ -1145,9 +1145,7 @@ class JournalEntry(AccountsController): def set_print_format_fields(self): bank_amount = party_amount = total_amount = 0.0 - currency = ( - bank_account_currency - ) = party_account_currency = pay_to_recd_from = self.pay_to_recd_from = None + currency = bank_account_currency = party_account_currency = pay_to_recd_from = None party_type = None for d in self.get("accounts"): if d.party_type in ["Customer", "Supplier"] and d.party: From 7e12332ea541f4634748751af734e47da778a759 Mon Sep 17 00:00:00 2001 From: ravibharathi656 Date: Mon, 21 Jul 2025 18:44:29 +0530 Subject: [PATCH 2/2] test: add test for pay_to_recd_from --- .../doctype/journal_entry/test_journal_entry.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/erpnext/accounts/doctype/journal_entry/test_journal_entry.py b/erpnext/accounts/doctype/journal_entry/test_journal_entry.py index c5d7f2920fd..b617ed3069f 100644 --- a/erpnext/accounts/doctype/journal_entry/test_journal_entry.py +++ b/erpnext/accounts/doctype/journal_entry/test_journal_entry.py @@ -579,6 +579,18 @@ class TestJournalEntry(IntegrationTestCase): ] self.assertEqual(expected, actual) + def test_pay_to_recd_from(self): + jv = make_journal_entry("_Test Cash - _TC", "_Test Bank - _TC", 100, save=False) + jv.pay_to_recd_from = "_Test Receiver" + jv.save() + self.assertEqual(jv.pay_to_recd_from, "_Test Receiver") + + jv.pay_to_recd_from = "_Test Receiver 2" + jv.save() + jv.submit() + + self.assertEqual(jv.pay_to_recd_from, "_Test Receiver 2") + def make_journal_entry( account1,