nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-09-15 01:43:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(selling): add email permission check on send_emails (backport #58935) (#58938)

Browse Source 
Co-authored-by: Diptanil Saha <diptanil@frappe.io>
This commit is contained in:
mergify[bot]
2026-09-09 16:04:33 +05:30
committed by GitHub
parent 53e53390f4
commit a79abc0462
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
erpnext/selling/doctype/customer/customer.py
View File

@@ -658,11 +658,8 @@ def check_credit_limit(customer, company, ignore_outstanding_sales_order=False,
# if the current user does not have permissions to override credit limit, # if the current user does not have permissions to override credit limit,
# prompt them to send out an email to the controller users # prompt them to send out an email to the controller users
frappe.msgprint( primary_action = (
message, {
title=_("Credit Limit Crossed"),
raise_exception=1,
primary_action={
"label": "Send Email", "label": "Send Email",
"server_action": "erpnext.selling.doctype.customer.customer.send_emails", "server_action": "erpnext.selling.doctype.customer.customer.send_emails",
"hide_on_success": True, "hide_on_success": True,
@@ -672,7 +669,16 @@ def check_credit_limit(customer, company, ignore_outstanding_sales_order=False,
"credit_limit": credit_limit, "credit_limit": credit_limit,
"credit_controller_users_list": credit_controller_users, "credit_controller_users_list": credit_controller_users,
}, },
}, }
if frappe.has_permission("Customer", ptype="email", doc=customer)
else None
)
frappe.msgprint(
message,
title=_("Credit Limit Crossed"),
raise_exception=1,
primary_action=primary_action,
) )
@@ -680,6 +686,7 @@ def check_credit_limit(customer, company, ignore_outstanding_sales_order=False,
def send_emails(customer, customer_outstanding, credit_limit, credit_controller_users_list): def send_emails(customer, customer_outstanding, credit_limit, credit_controller_users_list):
if isinstance(credit_controller_users_list, str): if isinstance(credit_controller_users_list, str):
credit_controller_users_list = json.loads(credit_controller_users_list) credit_controller_users_list = json.loads(credit_controller_users_list)
frappe.has_permission("Customer", ptype="email", doc=customer, throw=True)
subject = _("Credit limit reached for customer {0}").format(customer) subject = _("Credit limit reached for customer {0}").format(customer)
message = _("Credit limit has been crossed for customer {0} ({1}/{2})").format( message = _("Credit limit has been crossed for customer {0} ({1}/{2})").format(
customer, customer_outstanding, credit_limit customer, customer_outstanding, credit_limit