nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-06-03 04:09:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove advance payment ledgers on document deletion

Browse Source 
(cherry picked from commit 3c53b92f05)
This commit is contained in:
ruthra kumar
2024-10-16 17:26:20 +05:30
committed by Mergify
parent 54f758c327
commit a6c26874c7
2 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
erpnext/accounts/doctype/payment_entry/payment_entry.py
View File

@@ -191,6 +191,7 @@ class PaymentEntry(AccountsController):
"Repost Accounting Ledger Items", "Repost Accounting Ledger Items",
"Unreconcile Payment", "Unreconcile Payment",
"Unreconcile Payment Entries", "Unreconcile Payment Entries",
"Advance Payment Ledger Entry",
) )
super().on_cancel() super().on_cancel()
self.make_gl_entries(cancel=1) self.make_gl_entries(cancel=1)

5
erpnext/controllers/accounts_controller.py
View File

@@ -345,9 +345,14 @@ class AccountsController(TransactionBase):
repost_doc.flags.ignore_links = True repost_doc.flags.ignore_links = True
repost_doc.save(ignore_permissions=True) repost_doc.save(ignore_permissions=True)
def _remove_advance_payment_ledger_entries(self):
adv = qb.DocType("Advance Payment Ledger Entry")
qb.from_(adv).delete().where(adv.voucher_type.eq(self.doctype) & adv.voucher_no.eq(self.name)).run()
def on_trash(self): def on_trash(self):
from erpnext.accounts.utils import delete_exchange_gain_loss_journal from erpnext.accounts.utils import delete_exchange_gain_loss_journal
self._remove_advance_payment_ledger_entries()
self._remove_references_in_repost_doctypes() self._remove_references_in_repost_doctypes()
self._remove_references_in_unreconcile() self._remove_references_in_unreconcile()
self.remove_serial_and_batch_bundle() self.remove_serial_and_batch_bundle()