nsinnovations/erpnext
2
0
Fork 0
mirror of https://github.com/frappe/erpnext.git synced 2026-05-12 17:51:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: utility to convert tuple key to str

Browse Source 
(cherry picked from commit 5b464ae4c1)
This commit is contained in:
ruthra kumar
2025-10-17 19:48:35 +05:30
committed by Mergify
parent 347a7e3b1f
commit a624ae07f0
1 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
erpnext/accounts/doctype/process_period_closing_voucher/process_period_closing_voucher.py
View File

@@ -277,6 +277,20 @@ def schedule_next_date(docname: str):
summarize_and_post_ledger_entries(docname) summarize_and_post_ledger_entries(docname)
def make_dict_json_compliant(dimension_wise_balance) -> dict:
"""
convert tuple -> str
JSON doesn't support dictionary with tuple keys
"""
converted_dict = {}
for k, v in dimension_wise_balance.items():
str_key = [str(x) for x in k]
str_key = ",".join(str_key)
converted_dict[str_key] = v
return converted_dict
def summarize_and_post_ledger_entries(docname): def summarize_and_post_ledger_entries(docname):
# calculate balances for whole PCV period # calculate balances for whole PCV period
ppcv = frappe.get_doc("Process Period Closing Voucher", docname) ppcv = frappe.get_doc("Process Period Closing Voucher", docname)
@@ -291,14 +305,8 @@ def summarize_and_post_ledger_entries(docname):
# build dimension wise dictionary from all GLE's # build dimension wise dictionary from all GLE's
pl_dimension_wise_acc_balance = build_dimension_wise_balance_dict(gl_entries) pl_dimension_wise_acc_balance = build_dimension_wise_balance_dict(gl_entries)
# convert tuple key to str to make it json compliant
json_dict = {}
for k, v in pl_dimension_wise_acc_balance.items():
str_key = [str(x) for x in k]
str_key = ",".join(str_key)
json_dict[str_key] = v
# save # save
json_dict = make_dict_json_compliant(pl_dimension_wise_acc_balance)
frappe.db.set_value( frappe.db.set_value(
"Process Period Closing Voucher", docname, "p_l_closing_balance", frappe.json.dumps(json_dict) "Process Period Closing Voucher", docname, "p_l_closing_balance", frappe.json.dumps(json_dict)
) )
@@ -332,14 +340,8 @@ def summarize_and_post_ledger_entries(docname):
# build dimension wise dictionary from all GLE's # build dimension wise dictionary from all GLE's
bs_dimension_wise_acc_balance = build_dimension_wise_balance_dict(gl_entries) bs_dimension_wise_acc_balance = build_dimension_wise_balance_dict(gl_entries)
# convert tuple key to str to make it json compliant
json_dict = {}
for k, v in bs_dimension_wise_acc_balance.items():
str_key = [str(x) for x in k]
str_key = ",".join(str_key)
json_dict[str_key] = v
# save # save
json_dict = make_dict_json_compliant(bs_dimension_wise_acc_balance)
frappe.db.set_value( frappe.db.set_value(
"Process Period Closing Voucher", docname, "bs_closing_balance", frappe.json.dumps(json_dict) "Process Period Closing Voucher", docname, "bs_closing_balance", frappe.json.dumps(json_dict)
) )